Netdev List
 help / color / mirror / Atom feed
From: Konstantin Meshkov <skyline@mail.ru>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Aleksander Jan Bajkowski <olek2@wp.pl>,
	Christian Marangi <ansuelsmth@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH net-next] net: phy: marvell: add LED support for 88E1116R PHY
Date: Fri, 09 Oct 2026 09:08:29 +0300	[thread overview]
Message-ID: <179152610952.2918676.6625057760354797023@mail.ru> (raw)

The Marvell 88E1116R PHY (used on the D-Link DNS-325) exposes its LEDs
through the same page 3 register 0x10 LED control layout as the 88E1318S.
Wire up the existing 88E1318S LED handlers in the 88E1116R driver entry
so the PHY LEDs can be described in the device tree and driven through
the LED trigger API with hardware offload.

The LED polarity is configured through the led_polarity_set() callback
shared with the 88E1318S family.

Signed-off-by: Konstantin Meshkov <skyline@mail.ru>
---
This patch depends on:
[PATCH net-next v2] net: phy: marvell: add support for PHY LEDs polarity modes
https://patchwork.kernel.org/project/netdevbpf/patch/20260923204614.471409-1-olek2@wp.pl/

 drivers/net/phy/marvell.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index d57fcab..3b6c504 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -3949,6 +3949,12 @@ static struct phy_driver marvell_drivers[] = {
 		.get_stats = marvell_get_stats,
 		.get_tunable = m88e1011_get_tunable,
 		.set_tunable = m88e1011_set_tunable,
+		.led_polarity_set = m88e1318_led_polarity_set,
+		.led_brightness_set = m88e1318_led_brightness_set,
+		.led_blink_set = m88e1318_led_blink_set,
+		.led_hw_is_supported = m88e1318_led_hw_is_supported,
+		.led_hw_control_set = m88e1318_led_hw_control_set,
+		.led_hw_control_get = m88e1318_led_hw_control_get,
 	},
 	{
 		.phy_id = MARVELL_PHY_ID_88E1510,
-- 
2.39.5


             reply	other threads:[~2026-10-09  6:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  6:08 Konstantin Meshkov [this message]
2026-10-09 12:15 ` [PATCH net-next] net: phy: marvell: add LED support for 88E1116R PHY Andrew Lunn
2026-10-09 18:33   ` Konstantin Meshkov
2026-10-09 20:40   ` Aleksander Jan Bajkowski
2026-10-09 20:51 ` kernel test robot
2026-10-09 20:51 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179152610952.2918676.6625057760354797023@mail.ru \
    --to=skyline@mail.ru \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olek2@wp.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox