Re: [PATCH net-next v2 02/11] net: ethernet: qualcomm: ppe: Fix multicast queue config table access

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit "net: ethernet: qualcomm: ppe: Fix multicast queue
  config table access" fixes a real hardware misconfiguration bug in…

--

net: ethernet: qualcomm: ppe: Fix multicast queue config table access

This commit fixes ppe_config_qm() so that the multicast queue
configuration table is indexed relative to the first multicast queue
instead of by the absolute queue ID. It also shrinks
multicast_queue_cfg[] from 5 to 3 words to match the table entry size.

> Fix it by converting the queue ID to the index of the multicast queue
> configuration table and accessing only the 3 words of the entry.
>
> Signed-off-by: Luo Jie <jie.luo@oss.qualcomm.com>

[Severity: Low]
Should this have a Fixes: tag? Commit 806268dc7efd added both the
multicast_queue_cfg[5] declaration and the absolute queue_id indexing:

Fixes: 806268dc7efd ("net: ethernet: qualcomm: Initialize PPE queue management for IPQ9574")

ipq9574_ppe_qm_queue_config[] covers multicast queues 256 to 299. That
means kernels which already have the IPQ9574 PPE QM code take the broken
else branch in ppe_config_qm() on every probe.

Since this fixes code that is already merged, could it be sent on its
own to net with the Fixes: tag, rather than as part of the IPQ5424
series?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261011-qcom_ipq5424_ppe-v2-0-8c7b057e2c43%40oss.qualcomm.com