[PATCH net-next v2] net: phy: marvell: add LED support for 88E1116R PHY

[PATCH net-next v2] net: phy: marvell: add LED support for 88E1116R PHY

[Konstantin Meshkov]

The Marvell 88E1116R PHY (used on the D-Link DNS-325) exposes its LEDs
through the same page 3 register 0x10 LED control layout as the 88E1318S.
Wire up the existing 88E1318S LED handlers in the 88E1116R driver entry
so the PHY LEDs can be described in the device tree and driven through
the LED trigger API with hardware offload.

Tested on a D-Link DNS-325 (88E1116R): both PHY LEDs are registered and
hardware-offloaded.

Signed-off-by: Konstantin Meshkov <skyline@mail.ru>
---
Changes in v2:
- Only wire up the LED trigger handlers; drop the led_polarity_set
  assignment and the dependency on the pending PHY LED polarity
  series, as suggested by Aleksander Jan Bajkowski. LED polarity
  for the 88E1116R will be handled there.
- Rebased on current net-next.
- Cc the netdev maintainers.
v1: https://lore.kernel.org/netdev/179152610952.2918676.6625057760354797023@mail.ru/

 drivers/net/phy/marvell.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index f71cffa..244454f 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -3913,6 +3913,11 @@ static struct phy_driver marvell_drivers[] = {
 		.get_stats = marvell_get_stats,
 		.get_tunable = m88e1011_get_tunable,
 		.set_tunable = m88e1011_set_tunable,
+		.led_brightness_set = m88e1318_led_brightness_set,
+		.led_blink_set = m88e1318_led_blink_set,
+		.led_hw_is_supported = m88e1318_led_hw_is_supported,
+		.led_hw_control_set = m88e1318_led_hw_control_set,
+		.led_hw_control_get = m88e1318_led_hw_control_get,
 	},
 	{
 		.phy_id = MARVELL_PHY_ID_88E1510,
-- 
2.39.5

Re: [PATCH net-next v2] net: phy: marvell: add LED support for 88E1116R PHY

[Andrew Lunn]

On Sat, Oct 10, 2026 at 09:35:37PM +0300, Konstantin Meshkov wrote:
> The Marvell 88E1116R PHY (used on the D-Link DNS-325) exposes its LEDs
> through the same page 3 register 0x10 LED control layout as the 88E1318S.
> Wire up the existing 88E1318S LED handlers in the 88E1116R driver entry
> so the PHY LEDs can be described in the device tree and driven through
> the LED trigger API with hardware offload.
> 
> Tested on a D-Link DNS-325 (88E1116R): both PHY LEDs are registered and
> hardware-offloaded.
> 
> Signed-off-by: Konstantin Meshkov <skyline@mail.ru>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next v2] net: phy: marvell: add LED support for 88E1116R PHY

[Andrew Lunn]

On Sat, Oct 10, 2026 at 09:35:37PM +0300, Konstantin Meshkov wrote:
> The Marvell 88E1116R PHY (used on the D-Link DNS-325) exposes its LEDs
> through the same page 3 register 0x10 LED control layout as the 88E1318S.
> Wire up the existing 88E1318S LED handlers in the 88E1116R driver entry
> so the PHY LEDs can be described in the device tree and driven through
> the LED trigger API with hardware offload.
> 
> Tested on a D-Link DNS-325 (88E1116R): both PHY LEDs are registered and
> hardware-offloaded.
> 
> Signed-off-by: Konstantin Meshkov <skyline@mail.ru>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next v2] net: phy: marvell: add LED support for 88E1116R PHY

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 10 Oct 2026 21:35:37 +0300 you wrote:
> The Marvell 88E1116R PHY (used on the D-Link DNS-325) exposes its LEDs
> through the same page 3 register 0x10 LED control layout as the 88E1318S.
> Wire up the existing 88E1318S LED handlers in the 88E1116R driver entry
> so the PHY LEDs can be described in the device tree and driven through
> the LED trigger API with hardware offload.
> 
> Tested on a D-Link DNS-325 (88E1116R): both PHY LEDs are registered and
> hardware-offloaded.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: phy: marvell: add LED support for 88E1116R PHY
    https://git.kernel.org/netdev/net-next/c/ce7db1caaa68

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html