[PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem

[PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem

[Paolo Abeni]

New knobs should default to 'n'. The mentioned one depends on
BT_HCIBTUSB, but the latter is enabled on most systems.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
this is a last minute fixlet to avoid breaking expectation for the
upcoming net-next PR. I'll merge it in a matter of minutes unless
someone scream very loudly very soon!
---
 drivers/bluetooth/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index db0189ca3cbe..0dca5e43edc5 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -96,13 +96,12 @@ config BT_HCIBTUSB_QCOM
 	select FW_LOADER
 	select GPIOLIB
 	select WANT_DEV_COREDUMP
-	default y
+	default n
 	help
 	  Enables various required support, such as configuration, firmware
 	  download, and error recovery, for Qualcomm Bluetooth controllers.
 
 	  Say Y here to compile support for Qualcomm protocol.
-	  If unsure, say Y.
 
 config BT_HCIBTSDIO
 	tristate "HCI SDIO driver"
-- 
2.56.0

Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem

[Jakub Kicinski]

On Thu, 22 Oct 2026 17:38:06 +0200 Paolo Abeni wrote:
> New knobs should default to 'n'. The mentioned one depends on
> BT_HCIBTUSB, but the latter is enabled on most systems.

FTR added by commit:

3669487308f8 (Bluetooth: btusb: Add support for Qualcomm multi-subsystem QCC2072, 2026-09-13)

 drivers/bluetooth/Kconfig      |   14 +
 drivers/bluetooth/Makefile     |    1 +
 drivers/bluetooth/btusb_qcom.h |   99 +
 drivers/bluetooth/btusb_main.c |  121 ++
 drivers/bluetooth/btusb_qcom.c | 4557 ++++++++++++++++++++++++++++++++++++++++
 5 files changed, 4792 insertions(+)

so this is clearly gating new code, by Linus law the Kconfig should
default to disabled.

Acked-by: Jakub Kicinski <kuba@kernel.org>

Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem

[Luiz Augusto von Dentz]

Hi Paolo,

On Thu, Oct 22, 2026 at 11:38 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> New knobs should default to 'n'. The mentioned one depends on
> BT_HCIBTUSB, but the latter is enabled on most systems.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> this is a last minute fixlet to avoid breaking expectation for the
> upcoming net-next PR. I'll merge it in a matter of minutes unless
> someone scream very loudly very soon!
> ---
>  drivers/bluetooth/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index db0189ca3cbe..0dca5e43edc5 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -96,13 +96,12 @@ config BT_HCIBTUSB_QCOM
>         select FW_LOADER
>         select GPIOLIB
>         select WANT_DEV_COREDUMP
> -       default y
> +       default n
>         help
>           Enables various required support, such as configuration, firmware
>           download, and error recovery, for Qualcomm Bluetooth controllers.
>
>           Say Y here to compile support for Qualcomm protocol.
> -         If unsure, say Y.
>
>  config BT_HCIBTSDIO
>         tristate "HCI SDIO driver"
> --
> 2.56.0

Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

@Zijun Hu lets us know if you have any problem with it being default
n, perhaps it can be default y for a specific Qualcomm platform but
not in general.

-- 
Luiz Augusto von Dentz

Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 22 Oct 2026 17:38:06 +0200 you wrote:
> New knobs should default to 'n'. The mentioned one depends on
> BT_HCIBTUSB, but the latter is enabled on most systems.
> 
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> this is a last minute fixlet to avoid breaking expectation for the
> upcoming net-next PR. I'll merge it in a matter of minutes unless
> someone scream very loudly very soon!
> 
> [...]

Here is the summary with links:
  - [net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
    https://git.kernel.org/netdev/net-next/c/1a2c35c49cc7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem

[Paolo Abeni]

On 10/22/26 17:44, Luiz Augusto von Dentz wrote:
> Hi Paolo,
> 
> On Thu, Oct 22, 2026 at 11:38 AM Paolo Abeni <pabeni@redhat.com> wrote:
>>
>> New knobs should default to 'n'. The mentioned one depends on
>> BT_HCIBTUSB, but the latter is enabled on most systems.
>>
>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>> ---
>> this is a last minute fixlet to avoid breaking expectation for the
>> upcoming net-next PR. I'll merge it in a matter of minutes unless
>> someone scream very loudly very soon!
>> ---
>>   drivers/bluetooth/Kconfig | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
>> index db0189ca3cbe..0dca5e43edc5 100644
>> --- a/drivers/bluetooth/Kconfig
>> +++ b/drivers/bluetooth/Kconfig
>> @@ -96,13 +96,12 @@ config BT_HCIBTUSB_QCOM
>>          select FW_LOADER
>>          select GPIOLIB
>>          select WANT_DEV_COREDUMP
>> -       default y
>> +       default n
>>          help
>>            Enables various required support, such as configuration, firmware
>>            download, and error recovery, for Qualcomm Bluetooth controllers.
>>
>>            Say Y here to compile support for Qualcomm protocol.
>> -         If unsure, say Y.
>>
>>   config BT_HCIBTSDIO
>>          tristate "HCI SDIO driver"
>> --
>> 2.56.0
> 
> Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Thank you _a lot_ for the very prompt reply. Really appreciated and
really useful!

+1 on my beer-o-matic :)

/P

Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem

[Zijun Hu]

On 10/22/2026 11:44 PM, Luiz Augusto von Dentz wrote:
> @Zijun Hu lets us know if you have any problem with it being default
> n, perhaps it can be default y for a specific Qualcomm platform but
> not in general.
Hi Luiz,Paolo,Jakub

Default to y for the following reasons:
1) Avoid regressions when moving support for many existing Qualcomm controllers from btusb_main.c to btusb_qcom.c
2) Align with BT_HCIBTUSB_BCM and BT_HCIBTUSB_RTL, which also default to y.
3) USB devices are hotpluggable