* Re: [PATCH] ieee802154: drop the extra phy reference in del_iface
2026-11-04 2:28 [PATCH] ieee802154: drop the extra phy reference in del_iface Wentao Liang
@ 2026-11-04 2:32 ` netdev-bot+sinfo
2026-11-04 7:41 ` Krzysztof Kozlowski
2026-11-16 15:04 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: netdev-bot+sinfo @ 2026-11-04 2:32 UTC (permalink / raw)
To: Wentao Liang
Cc: Alexander Aring, Stefan Schmidt, Miquel Raynal, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
linux-wpan, netdev
Hi!
This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:
- How the issue was discovered, e.g. hit in production, hit during
development, syzbot report, manual code inspection, LLM or static
analysis tool scan.
- Whether the issue was actually triggered, or is only theoretical
(e.g. found by code inspection). If it was triggered please include
the symptoms, like the stack trace or error messages.
Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account. If the series needs another revision for
other reasons, please include the information in the commit messages
then.
The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ieee802154: drop the extra phy reference in del_iface
2026-11-04 2:28 [PATCH] ieee802154: drop the extra phy reference in del_iface Wentao Liang
2026-11-04 2:32 ` netdev-bot+sinfo
@ 2026-11-04 7:41 ` Krzysztof Kozlowski
2026-11-16 15:04 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-04 7:41 UTC (permalink / raw)
To: Wentao Liang
Cc: netdev, linux-wpan, Alexander Aring, Simon Horman, Stefan Schmidt,
David S. Miller, Eric Dumazet, Miquel Raynal, Paolo Abeni,
Jakub Kicinski
On Wed, 04 Nov 2026 02:28:09 +0000, Wentao Liang wrote:
> ieee802154_del_iface() takes a reference on the phy of the interface and
> then looks up the phy named by IEEE802154_ATTR_PHY_NAME, which takes
> another reference. When the optional attribute names the phy of the
> interface being deleted, phy and phy2 are the same device, the lookup
> reference is not dropped and the function later puts the phy only once.
> Deleting an interface while passing its own phy name therefore leaks a
> wpan_phy reference.
>
> Put the lookup reference in the matching case as well, leaving only the
> reference taken from the interface.
>
> Fixes: bb1cafb8fc41 ("ieee802154: add support for creation/removal of logic interfaces")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> net/ieee802154/nl-phy.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.
2. You use multiple identities with this email address, thus I doubt that we
speak with an actual person.
3. Your bot does not even bother running checkpatch, right?
4. Nothing of this was reproduced nor tested.
5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.
More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.
This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down. Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.
Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document the issue discovery method and what was
or was not tested.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ieee802154: drop the extra phy reference in del_iface
2026-11-04 2:28 [PATCH] ieee802154: drop the extra phy reference in del_iface Wentao Liang
2026-11-04 2:32 ` netdev-bot+sinfo
2026-11-04 7:41 ` Krzysztof Kozlowski
@ 2026-11-16 15:04 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2026-11-16 15:04 UTC (permalink / raw)
To: Wentao Liang
Cc: Alexander Aring, Stefan Schmidt, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, linux-wpan, netdev
On 04/11/2026 at 02:28:09 GMT, Wentao Liang <vulab@iscas.ac.cn> wrote:
> ieee802154_del_iface() takes a reference on the phy of the interface and
> then looks up the phy named by IEEE802154_ATTR_PHY_NAME, which takes
> another reference. When the optional attribute names the phy of the
> interface being deleted, phy and phy2 are the same device, the lookup
> reference is not dropped and the function later puts the phy only once.
> Deleting an interface while passing its own phy name therefore leaks a
> wpan_phy reference.
>
> Put the lookup reference in the matching case as well, leaving only the
> reference taken from the interface.
>
> Fixes: bb1cafb8fc41 ("ieee802154: add support for creation/removal of logic interfaces")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
^ permalink raw reply [flat|nested] 4+ messages in thread