Netdev List
 help / color / mirror / Atom feed
* [net PATCH 0/6] fbnic: Follow-up fixes for the Tx idle check, HW stats and FW mailbox allocations
@ 2026-11-13 20:41 Alexander Duyck
  2026-11-13 20:41 ` [net PATCH 1/6] fbnic: Wait for in-flight PTP timestamps before treating Tx as idle Alexander Duyck
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Alexander Duyck @ 2026-11-13 20:41 UTC (permalink / raw)
  To: netdev; +Cc: andrew+netdev, davem, edumazet, horms, kernel-team, kuba, pabeni

Follow-up fixes for fbnic on top of the series that was just applied
to net, plus two fixes for FW mailbox allocations under memory pressure.

Patch 1 makes the Tx idle check wait for in-flight PTP timestamps. The
QM idle registers do not cover the TMI completion path, so they can
report idle while a timestamp completion is still outstanding.

Patches 2-4 fix the HW stats: patch 2 stops a failed register read, as
every read is during DPC recovery, from being folded into the totals;
patch 3 puts all of the stats under the stats lock, as the MAC stats
getters no longer run under RTNL; patch 4 captures the baselines before
the stats can be read, at probe and on resume, where they are now
rebased as MMIO access returns.

Patches 5 and 6 address heartbeat failures seen on production hosts
during host memory stalls: the heartbeat and ownership requests are
stamped after their message is allocated, and FW completions, which
carry the whole coredump, are allocated with kvzalloc and the dump size
is bounded.

Patches 1, 3 and 4 were found by code review, the PTP completion
behaviour confirmed against the RTL; patches 2 and 3 were confirmed by
hardware testing with forced AER/DPC recovery, and patches 5 and 6
address failures seen on production hosts. Tested on QEMU with the fbnic
device model, and on a Yosemite V4 host with forced AER/DPC recovery
while reading the stats.

---

Alexander Duyck (6):
      fbnic: Wait for in-flight PTP timestamps before treating Tx as idle
      fbnic: Do not accumulate HW stats from failed register reads
      fbnic: Cover all of the HW stats with the stats lock
      fbnic: Initialize and reset the HW stats before they can be read
      fbnic: Stamp heartbeat and ownership requests after allocating them
      fbnic: Allocate FW completions with kvzalloc


 drivers/net/ethernet/meta/fbnic/fbnic_csr.h   |  3 +-
 .../net/ethernet/meta/fbnic/fbnic_debugfs.c   |  3 -
 .../net/ethernet/meta/fbnic/fbnic_devlink.c   |  5 ++
 .../net/ethernet/meta/fbnic/fbnic_ethtool.c   |  8 ++
 drivers/net/ethernet/meta/fbnic/fbnic_fw.c    | 19 +++--
 drivers/net/ethernet/meta/fbnic/fbnic_fw.h    |  5 ++
 .../net/ethernet/meta/fbnic/fbnic_hw_stats.c  | 32 ++++----
 .../net/ethernet/meta/fbnic/fbnic_hw_stats.h  |  1 +
 drivers/net/ethernet/meta/fbnic/fbnic_mac.c   |  8 ++
 drivers/net/ethernet/meta/fbnic/fbnic_pci.c   | 16 ++--
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c  | 73 +++++++++++++++----
 11 files changed, 131 insertions(+), 42 deletions(-)

--


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-11-17 22:12 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13 20:41 [net PATCH 0/6] fbnic: Follow-up fixes for the Tx idle check, HW stats and FW mailbox allocations Alexander Duyck
2026-11-13 20:41 ` [net PATCH 1/6] fbnic: Wait for in-flight PTP timestamps before treating Tx as idle Alexander Duyck
2026-11-17 21:14   ` netdev-bot+sashiko
2026-11-17 21:31     ` Alexander Duyck
2026-11-13 20:41 ` [net PATCH 2/6] fbnic: Do not accumulate HW stats from failed register reads Alexander Duyck
2026-11-17 21:14   ` netdev-bot+sashiko
2026-11-17 22:11     ` Alexander Duyck
2026-11-13 20:41 ` [net PATCH 3/6] fbnic: Cover all of the HW stats with the stats lock Alexander Duyck
2026-11-17 21:14   ` netdev-bot+sashiko
2026-11-17 22:01     ` Alexander Duyck
2026-11-13 20:41 ` [net PATCH 4/6] fbnic: Initialize and reset the HW stats before they can be read Alexander Duyck
2026-11-13 20:42 ` [net PATCH 5/6] fbnic: Stamp heartbeat and ownership requests after allocating them Alexander Duyck
2026-11-13 20:42 ` [net PATCH 6/6] fbnic: Allocate FW completions with kvzalloc Alexander Duyck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox