Netdev List
 help / color / mirror / Atom feed
* [PATCH net] selftests: drv-net: psp: skip unsupported versions in netkit data test
@ 2026-11-15 13:03 Alexey Skidanov via B4 Relay
  2026-11-16  2:44 ` Wei Wang
  2026-11-18  1:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Alexey Skidanov via B4 Relay @ 2026-11-15 13:03 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Shuah Khan, Wei Wang
  Cc: netdev, linux-kselftest, linux-kernel, guyt, Alexey Skidanov,
	Lior Yizchak

From: Alexey Skidanov <alexeys@xsightlabs.com>

data_basic_send_netkit_psp_assoc() runs for PSP versions 0-3. The
non-netkit data path already skips versions the device does not
advertise in psp-versions-cap. The netkit path does not, so those
cases fail instead of skipping.

Version 0 stays mandatory. Skip an unadvertised version before opening
the PSP connection.

Fixes: 43cf629700fa ("selftests/net: psp: add dev-assoc data path test")
Signed-off-by: Alexey Skidanov <alexeys@xsightlabs.com>
Signed-off-by: Lior Yizchak <liory@xsightlabs.com>
---
 tools/testing/selftests/drivers/net/psp.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/testing/selftests/drivers/net/psp.py b/tools/testing/selftests/drivers/net/psp.py
index c114d2245135..7c8fb2200b39 100755
--- a/tools/testing/selftests/drivers/net/psp.py
+++ b/tools/testing/selftests/drivers/net/psp.py
@@ -728,6 +728,12 @@ def _data_basic_send_netkit_psp_assoc(cfg, version, ipver):
     """
     _assoc_nk_guest(cfg)
 
+    # Version 0 is required by spec, don't let it skip
+    if version:
+        name = cfg.pspnl.consts["version"].entries_by_val[version].name
+        if name not in cfg.psp_info['psp-versions-cap']:
+            raise KsftSkipEx("PSP version not supported", name)
+
     # Enter guest namespace (netns) to run PSP test
     with NetNSEnter(cfg.netns.name):
         cfg.pspnl = PSPFamily()

---
base-commit: aa40afa831ebfe45e40a23721711059f2ac584d4
change-id: 20261115-main-0b37fbe5e1d2

Best regards,
-- 
Alexey Skidanov <alexeys@xsightlabs.com>



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: drv-net: psp: skip unsupported versions in netkit data test
  2026-11-15 13:03 [PATCH net] selftests: drv-net: psp: skip unsupported versions in netkit data test Alexey Skidanov via B4 Relay
@ 2026-11-16  2:44 ` Wei Wang
  2026-11-18  1:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Wei Wang @ 2026-11-16  2:44 UTC (permalink / raw)
  To: alexeys
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Shuah Khan, netdev, linux-kselftest, linux-kernel,
	guyt, Lior Yizchak

On Sun, Nov 15, 2026 at 5:03 AM Alexey Skidanov via B4 Relay
<devnull+alexeys.xsightlabs.com@kernel.org> wrote:
>
> From: Alexey Skidanov <alexeys@xsightlabs.com>
>
> data_basic_send_netkit_psp_assoc() runs for PSP versions 0-3. The
> non-netkit data path already skips versions the device does not
> advertise in psp-versions-cap. The netkit path does not, so those
> cases fail instead of skipping.
>
> Version 0 stays mandatory. Skip an unadvertised version before opening
> the PSP connection.
>
> Fixes: 43cf629700fa ("selftests/net: psp: add dev-assoc data path test")
> Signed-off-by: Alexey Skidanov <alexeys@xsightlabs.com>
> Signed-off-by: Lior Yizchak <liory@xsightlabs.com>
> ---

Reviewed-by: Wei Wang <weiwan@google.com>

>  tools/testing/selftests/drivers/net/psp.py | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/psp.py b/tools/testing/selftests/drivers/net/psp.py
> index c114d2245135..7c8fb2200b39 100755
> --- a/tools/testing/selftests/drivers/net/psp.py
> +++ b/tools/testing/selftests/drivers/net/psp.py
> @@ -728,6 +728,12 @@ def _data_basic_send_netkit_psp_assoc(cfg, version, ipver):
>      """
>      _assoc_nk_guest(cfg)
>
> +    # Version 0 is required by spec, don't let it skip
> +    if version:
> +        name = cfg.pspnl.consts["version"].entries_by_val[version].name
> +        if name not in cfg.psp_info['psp-versions-cap']:
> +            raise KsftSkipEx("PSP version not supported", name)
> +
>      # Enter guest namespace (netns) to run PSP test
>      with NetNSEnter(cfg.netns.name):
>          cfg.pspnl = PSPFamily()
>
> ---
> base-commit: aa40afa831ebfe45e40a23721711059f2ac584d4
> change-id: 20261115-main-0b37fbe5e1d2
>
> Best regards,
> --
> Alexey Skidanov <alexeys@xsightlabs.com>
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: drv-net: psp: skip unsupported versions in netkit data test
  2026-11-15 13:03 [PATCH net] selftests: drv-net: psp: skip unsupported versions in netkit data test Alexey Skidanov via B4 Relay
  2026-11-16  2:44 ` Wei Wang
@ 2026-11-18  1:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-11-18  1:40 UTC (permalink / raw)
  To: Alexey Skidanov
  Cc: andrew+netdev, davem, edumazet, kuba, pabeni, shuah, weiwan,
	netdev, linux-kselftest, linux-kernel, guyt, liory

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 15 Nov 2026 15:03:29 +0200 you wrote:
> From: Alexey Skidanov <alexeys@xsightlabs.com>
> 
> data_basic_send_netkit_psp_assoc() runs for PSP versions 0-3. The
> non-netkit data path already skips versions the device does not
> advertise in psp-versions-cap. The netkit path does not, so those
> cases fail instead of skipping.
> 
> [...]

Here is the summary with links:
  - [net] selftests: drv-net: psp: skip unsupported versions in netkit data test
    https://git.kernel.org/netdev/net-next/c/d3826f58a1ed

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-18  1:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15 13:03 [PATCH net] selftests: drv-net: psp: skip unsupported versions in netkit data test Alexey Skidanov via B4 Relay
2026-11-16  2:44 ` Wei Wang
2026-11-18  1:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox