Netdev List
 help / color / mirror / Atom feed
* [PATCH net 0/2] net: sparx5/lan969x: fix RX ring stall on frames from inactive ports
@ 2026-11-16  9:56 Daniel Machon
  2026-11-16  9:56 ` [PATCH net 1/2] net: sparx5: " Daniel Machon
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Daniel Machon @ 2026-11-16  9:56 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Steen Hegelund, UNGLinuxDriver
  Cc: Zhang Hewei, netdev, linux-arm-kernel, linux-kernel

On Sparx5 and lan969x, a received frame whose source port does not map
to an active port is never consumed from the FDMA RX ring: the NAPI poll
stops on it, and finds the same DB again on every following poll.

Patch 1 fixes Sparx5, where the same skb grows on every poll until
skb_over_panic().

Patch 2 fixes lan969x, where RX stops on all ports.

The issue was reported by Zhang Hewei, and these patches replace his
series [1]. Tested on Sparx5 and lan969x.

[1] https://lore.kernel.org/netdev/tencent_D2451CD0D7B4B812CEBADB56DC722BC33406@qq.com/

Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
---
Daniel Machon (2):
      net: sparx5: fix RX ring stall on frames from inactive ports
      net: lan969x: fix RX ring stall on frames from inactive ports

 drivers/net/ethernet/microchip/sparx5/lan969x/lan969x_fdma.c | 11 ++++++-----
 drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c          | 12 +++++++++---
 2 files changed, 15 insertions(+), 8 deletions(-)
---
base-commit: aa40afa831ebfe45e40a23721711059f2ac584d4
change-id: 20261116-sparx5-rx-inactive-port-df606d3f9b1a

Best regards,
-- 
Daniel Machon <daniel.machon@microchip.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH net 0/2] net: sparx5/lan969x: fix RX ring stall on frames from inactive ports
@ 2026-11-08 18:45 memoriaru
  2026-11-09  7:53 ` Daniel Machon
  0 siblings, 1 reply; 6+ messages in thread
From: memoriaru @ 2026-11-08 18:45 UTC (permalink / raw)
  To: netdev; +Cc: Steen.Hegelund, daniel.machon, UNGLinuxDriver, 79190669+memoriaru

From: Zhang Hewei <79190669+memoriaru@users.noreply.github.com>

The FDMA RX path on both sparx5 and its lan969x sibling stalls the RX
ring forever when the hardware delivers a frame whose source port does
not map to an active netdev.

In both drivers the RX NAPI loop only advances the software cursor
(fdma_db_advance/fdma_dcb_advance) after a frame has been successfully
delivered. When the source-port lookup fails:

  - sparx5 (sparx5_fdma_rx_get_frame()) logs an error, flushes the
    extraction FIFO and returns false without touching the cursor,
    leaving an skb_put()-extended skb behind in the rx->skb[][] array;
  - lan969x (lan969x_fdma_rx_get_frame()) recycles the page and returns
    NULL, which makes the poll loop break without touching the cursor.

Since the DCB still carries its hardware DONE bit, every subsequent
NAPI poll picks the same DCB again, takes the same inactive-port branch
and stops again: RX traffic on all ports stalls until the driver module
is reloaded. sparx5_xtr_flush() only drains the QS_XTR hardware FIFO
and does not clear the stall.

Patch 1 treats a bogus frame on sparx5 as consumed: free the skb, clear
the array slot and return true so the NAPI loop advances past the DB as
it does for any other received frame; the slot is refilled by the
dataptr callback when the DCB is recycled. Patch 2 splits the two NULL
meanings on lan969x (allocation failure, which keeps its retry-later
break, vs bogus frame) and advances past bogus frames in the poll loop.

Found by code inspection; the stall needs the hardware to emit a frame
with an invalid source port, which cannot be triggered without hardware.
Review from someone with access to sparx5/lan969x systems would be
appreciated.

Zhang Hewei (2):
  net: sparx5: fix RX ring stall on frames from inactive ports
  net: lan969x: fix RX ring stall on frames from inactive ports

 drivers/net/ethernet/microchip/sparx5/lan969x/lan969x_fdma.c | 18 ++++++++++++++--
 drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c          |  9 ++++++++-
 2 files changed, 25 insertions(+), 2 deletions(-)

-- 
2.39.5 (Apple Git-154)


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-18  3:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16  9:56 [PATCH net 0/2] net: sparx5/lan969x: fix RX ring stall on frames from inactive ports Daniel Machon
2026-11-16  9:56 ` [PATCH net 1/2] net: sparx5: " Daniel Machon
2026-11-16  9:56 ` [PATCH net 2/2] net: lan969x: " Daniel Machon
2026-11-18  3:00 ` [PATCH net 0/2] net: sparx5/lan969x: " patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2026-11-08 18:45 memoriaru
2026-11-09  7:53 ` Daniel Machon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox