* [PATCH net] inet: reject unhashed sockets during timewait purge
@ 2026-11-19 4:11 Wentao Guan
2026-11-19 4:17 ` netdev-bot+sinfo
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Guan @ 2026-11-19 4:11 UTC (permalink / raw)
To: edumazet, ncardwell, kuniyu, imv4bel
Cc: martin.lau, jiayuan.chen, netdev, stable, Wentao Guan
A shared ehash can retain a stale pointer that is recycled as an
unhashed SYN-cookie request from another dead namespace. The namespace
recheck alone accepts that request, and
inet_csk_reqsk_queue_drop_and_put() can then operate on an uninitialized
timer.
This is the inet_twsk_purge() counterpart of the validation added for
established lookups. Recheck the nulls node after taking the reference.
If it is unhashed, drop the reference and restart the purge instead of
operating on the recycled request.
Fixes: 4e2b3ef19e0e ("inet: reject unhashed sockets during established lookups")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
---
net/ipv4/inet_timewait_sock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c
index e256c55ce9f29..5601bd03b1382 100644
--- a/net/ipv4/inet_timewait_sock.c
+++ b/net/ipv4/inet_timewait_sock.c
@@ -333,7 +333,8 @@ void inet_twsk_purge(struct inet_hashinfo *hashinfo)
if (unlikely(!refcount_inc_not_zero_acquire(&sk->sk_refcnt)))
continue;
- if (check_net(sock_net(sk))) {
+ if (unlikely(hlist_nulls_unhashed_lockless(&sk->sk_nulls_node) ||
+ check_net(sock_net(sk)))) {
sock_gen_put(sk);
goto restart;
}
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] inet: reject unhashed sockets during timewait purge
2026-11-19 4:11 [PATCH net] inet: reject unhashed sockets during timewait purge Wentao Guan
@ 2026-11-19 4:17 ` netdev-bot+sinfo
0 siblings, 0 replies; 2+ messages in thread
From: netdev-bot+sinfo @ 2026-11-19 4:17 UTC (permalink / raw)
To: Wentao Guan
Cc: edumazet, ncardwell, kuniyu, imv4bel, martin.lau, jiayuan.chen,
netdev, stable
Hi!
This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:
- How the issue was discovered, e.g. hit in production, hit during
development, syzbot report, manual code inspection, LLM or static
analysis tool scan.
- Whether the issue was actually triggered, or is only theoretical
(e.g. found by LLM and not proven at runtime). If it was triggered
please include the symptoms, like the stack trace or kernel messages.
Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account.
*IMPORTANT*: If you do repost (for other reasons) - please include
the relevant info in the cover letter or commit messages.
--
The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-19 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 4:11 [PATCH net] inet: reject unhashed sockets during timewait purge Wentao Guan
2026-11-19 4:17 ` netdev-bot+sinfo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox