Netdev List
 help / color / mirror / Atom feed
* [PATCH net-next 0/4] net: enetc: Add i.MX952 support
@ 2026-11-18 10:37 Frieder Schrempf
  2026-11-18 10:37 ` [PATCH net-next 1/4] dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible Frieder Schrempf
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Frieder Schrempf @ 2026-11-18 10:37 UTC (permalink / raw)
  To: Claudiu Manoil, Vladimir Oltean, Wei Fang, Clark Wang,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Richard Cochran
  Cc: imx, netdev, devicetree, linux-kernel, Frieder Schrempf

This adds support for the NETC Ethernet controller on the i.MX952 SoC.

i.MX952 has two ENETC instances (IP revision 4.6), each on its own
PCIe bus. ENETC0 shares bus 0 with the NETC timer and the central EMDIO,
ENETC1 sits alone on bus 1. The NETC system clock runs at 133 MHz,
compared to 333 MHz on i.MX95.

The patches are ported from NXP's lf-6.18.y vendor kernel. The device
tree changes for imx952.dtsi and the i.MX952 EVK will be sent separately
to the i.MX tree.

Tested on the i.MX952 EVK with ENETC0 (RGMII): the link works,
hardware timestamping is available and the PHC runs at the correct
rate. ENETC1 is untested as it needs an add-on board.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
Clark Wang (2):
      net: enetc: netc_blk_ctrl: add i.MX952 support
      ptp: netc: use 133 MHz system clock on i.MX952

Frieder Schrempf (1):
      dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible

Wei Fang (1):
      net: enetc: add i.MX952 ENETC support

 .../devicetree/bindings/net/nxp,netc-blk-ctrl.yaml |  1 +
 drivers/net/ethernet/freescale/enetc/enetc.c       | 23 +++++++
 .../net/ethernet/freescale/enetc/enetc_ethtool.c   |  1 +
 drivers/net/ethernet/freescale/enetc/enetc_hw.h    |  2 +
 .../net/ethernet/freescale/enetc/netc_blk_ctrl.c   | 73 ++++++++++++++++++++++
 drivers/ptp/ptp_netc.c                             |  7 ++-
 6 files changed, 106 insertions(+), 1 deletion(-)
---
base-commit: d6816d9a93b66a12bf01e10037e377f3333ad6cc
change-id: 20261118-imx952-enetc-bd2bc331e1b5

Best regards,
--  
Frieder Schrempf <frieder.schrempf@kontron.de>


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH net-next 1/4] dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible
  2026-11-18 10:37 [PATCH net-next 0/4] net: enetc: Add i.MX952 support Frieder Schrempf
@ 2026-11-18 10:37 ` Frieder Schrempf
  2026-11-18 17:43   ` Conor Dooley
  2026-11-18 10:37 ` [PATCH net-next 2/4] net: enetc: netc_blk_ctrl: add i.MX952 support Frieder Schrempf
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 11+ messages in thread
From: Frieder Schrempf @ 2026-11-18 10:37 UTC (permalink / raw)
  To: Claudiu Manoil, Vladimir Oltean, Wei Fang, Clark Wang,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Richard Cochran
  Cc: imx, netdev, devicetree, linux-kernel, Frieder Schrempf

From: Frieder Schrempf <frieder.schrempf@kontron.de>

The NETC on i.MX952 has the same IERB, PRB and NETCMIX register blocks
as on i.MX95, but a different set of ENETC instances and a different
NETCMIX link configuration. Add a dedicated compatible string for it.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 Documentation/devicetree/bindings/net/nxp,netc-blk-ctrl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/nxp,netc-blk-ctrl.yaml b/Documentation/devicetree/bindings/net/nxp,netc-blk-ctrl.yaml
index deea4fd73d767..c443fe0b4693f 100644
--- a/Documentation/devicetree/bindings/net/nxp,netc-blk-ctrl.yaml
+++ b/Documentation/devicetree/bindings/net/nxp,netc-blk-ctrl.yaml
@@ -23,6 +23,7 @@ properties:
     enum:
       - nxp,imx94-netc-blk-ctrl
       - nxp,imx95-netc-blk-ctrl
+      - nxp,imx952-netc-blk-ctrl
 
   reg:
     maxItems: 3

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH net-next 2/4] net: enetc: netc_blk_ctrl: add i.MX952 support
  2026-11-18 10:37 [PATCH net-next 0/4] net: enetc: Add i.MX952 support Frieder Schrempf
  2026-11-18 10:37 ` [PATCH net-next 1/4] dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible Frieder Schrempf
@ 2026-11-18 10:37 ` Frieder Schrempf
  2026-11-18 13:51   ` Andrew Lunn
  2026-11-22 11:00   ` netdev-bot+sashiko
  2026-11-18 10:37 ` [PATCH net-next 3/4] net: enetc: add i.MX952 ENETC support Frieder Schrempf
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 11+ messages in thread
From: Frieder Schrempf @ 2026-11-18 10:37 UTC (permalink / raw)
  To: Claudiu Manoil, Vladimir Oltean, Wei Fang, Clark Wang,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Richard Cochran
  Cc: imx, netdev, devicetree, linux-kernel, Frieder Schrempf

From: Clark Wang <xiaoning.wang@nxp.com>

Add NETCMIX support for i.MX952 platform. i.MX952 has two ENETC
instances, each on its own PCIe bus: ENETC0 at bus 0 devfn 0 and ENETC1
at bus 1 devfn 0. Their link MII protocol is configured through the
same NETCMIX register as on i.MX95.

The i.MX952 RM describes E0TXHPTBCR and E0TXLPTBCR as the byte-credit
limits for the ENETC transmit datapath. Both ENETC0 transmit
byte-credit registers reset to 0x5dc, which matches the RM example for
a 1536-byte maximum frame size. That is too small once jumbo frames are
enabled when the NETCMIX root clock is 133 MHz: the credit counter is
exhausted too early, which reduces transmit throughput. Program them to
0xc35, the same as port 1, during IERB initialization.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
[fs: squashed NXP a9dd7adc7e44, 68415a57f31e]
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 .../net/ethernet/freescale/enetc/netc_blk_ctrl.c   | 73 ++++++++++++++++++++++
 1 file changed, 73 insertions(+)

diff --git a/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c b/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
index 658fab31e9ed7..6e3098a0a43ee 100644
--- a/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
+++ b/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
@@ -67,6 +67,8 @@
 #define IERB_EMDIOFAUXR			0x344
 #define IERB_T0FAUXR			0x444
 #define IERB_ETBCR(a)			(0x300c + 0x100 * (a))
+#define IERB_ETXHPTBCR(a)		(0x3070 + 0x100 * (a))
+#define IERB_ETXLPTBCR(a)		(0x3074 + 0x100 * (a))
 #define IERB_LBCR(a)			(0x1010 + 0x40 * (a))
 #define  LBCR_MDIO_PHYAD_PRTAD(addr)	(((addr) & 0x1f) << 8)
 
@@ -89,6 +91,10 @@
 #define IMX94_ENETC1_LINK		4
 #define IMX94_ENETC2_LINK		5
 
+#define IMX952_ENETC0_BUS_DEVFN		0x0
+#define IMX952_ENETC1_BUS_DEVFN		0x100
+#define IMX952_BYTE_CREDIT		0xc35
+
 #define NETC_ENETC_ID(a)		(a)
 #define NETC_TIMER_ID(a)		(a)
 
@@ -368,6 +374,56 @@ static int imx94_netcmix_init(struct platform_device *pdev)
 	return 0;
 }
 
+static int imx952_netcmix_init(struct platform_device *pdev)
+{
+	struct netc_blk_ctrl *priv = platform_get_drvdata(pdev);
+	struct device_node *np = pdev->dev.of_node;
+	phy_interface_t interface;
+	int bus_devfn, mii_proto;
+	u32 val;
+	int err;
+
+	/* Default setting */
+	val = MII_PROT(0, MII_PROT_RGMII) | MII_PROT(1, MII_PROT_RGMII);
+
+	/* Update the link MII protocol through parsing phy-mode */
+	for_each_child_of_node_scoped(np, child) {
+		for_each_child_of_node_scoped(child, gchild) {
+			if (!of_device_is_compatible(gchild, "pci1131,e101"))
+				continue;
+
+			bus_devfn = netc_of_pci_get_bus_devfn(gchild);
+			if (bus_devfn < 0)
+				return bus_devfn;
+
+			err = of_get_phy_mode(gchild, &interface);
+			if (err)
+				continue;
+
+			mii_proto = netc_get_link_mii_protocol(interface);
+			if (mii_proto < 0)
+				return mii_proto;
+
+			switch (bus_devfn) {
+			case IMX952_ENETC0_BUS_DEVFN:
+				val = u32_replace_bits(val, mii_proto,
+						       CFG_LINK_MII_PORT_0);
+				break;
+			case IMX952_ENETC1_BUS_DEVFN:
+				val = u32_replace_bits(val, mii_proto,
+						       CFG_LINK_MII_PORT_1);
+				break;
+			default:
+				return -EINVAL;
+			}
+		}
+	}
+
+	netc_reg_write(priv->netcmix, IMX95_CFG_LINK_MII_PROT, val);
+
+	return 0;
+}
+
 static bool netc_ierb_is_locked(struct netc_blk_ctrl *priv)
 {
 	return !!(netc_reg_read(priv->prb, PRB_NETCRR) & NETCRR_LOCK);
@@ -783,6 +839,16 @@ static int imx94_ierb_init(struct platform_device *pdev)
 	return 0;
 }
 
+static int imx952_ierb_init(struct platform_device *pdev)
+{
+	struct netc_blk_ctrl *priv = platform_get_drvdata(pdev);
+
+	netc_reg_write(priv->ierb, IERB_ETXHPTBCR(0), IMX952_BYTE_CREDIT);
+	netc_reg_write(priv->ierb, IERB_ETXLPTBCR(0), IMX952_BYTE_CREDIT);
+
+	return 0;
+}
+
 static int netc_ierb_init(struct platform_device *pdev)
 {
 	struct netc_blk_ctrl *priv = platform_get_drvdata(pdev);
@@ -882,8 +948,15 @@ static const struct netc_devinfo imx94_devinfo = {
 	.ierb_init = imx94_ierb_init,
 };
 
+static const struct netc_devinfo imx952_devinfo = {
+	.flags = NETC_HAS_NETCMIX,
+	.netcmix_init = imx952_netcmix_init,
+	.ierb_init = imx952_ierb_init,
+};
+
 static const struct of_device_id netc_blk_ctrl_match[] = {
 	{ .compatible = "nxp,imx95-netc-blk-ctrl", .data = &imx95_devinfo },
+	{ .compatible = "nxp,imx952-netc-blk-ctrl", .data = &imx952_devinfo },
 	{ .compatible = "nxp,imx94-netc-blk-ctrl", .data = &imx94_devinfo },
 	{},
 };

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH net-next 3/4] net: enetc: add i.MX952 ENETC support
  2026-11-18 10:37 [PATCH net-next 0/4] net: enetc: Add i.MX952 support Frieder Schrempf
  2026-11-18 10:37 ` [PATCH net-next 1/4] dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible Frieder Schrempf
  2026-11-18 10:37 ` [PATCH net-next 2/4] net: enetc: netc_blk_ctrl: add i.MX952 support Frieder Schrempf
@ 2026-11-18 10:37 ` Frieder Schrempf
  2026-11-22 11:00   ` netdev-bot+sashiko
  2026-11-18 10:37 ` [PATCH net-next 4/4] ptp: netc: use 133 MHz system clock on i.MX952 Frieder Schrempf
  2026-11-18 10:43 ` [PATCH net-next 0/4] net: enetc: Add i.MX952 support Clark Wang
  4 siblings, 1 reply; 11+ messages in thread
From: Frieder Schrempf @ 2026-11-18 10:37 UTC (permalink / raw)
  To: Claudiu Manoil, Vladimir Oltean, Wei Fang, Clark Wang,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Richard Cochran
  Cc: imx, netdev, devicetree, linux-kernel, Frieder Schrempf

From: Wei Fang <wei.fang@nxp.com>

The ENETC driver gets some IP information based on the revision. If the
corresponding revision is not present in enetc_info array, the driver
will probe fail. Since the ENETC revision of i.MX952 is 4.6, so add
relevant data to enetc_info. In addition, update
enetc_get_phc_index_by_pdev() to ensure that PTP related functions work
properly.

To enable SGMII 1G, 133 MHz is required as the sysclk of ENETC on
i.MX952, so the driver data of revision 4.6 uses a 133 MHz sysclk_freq.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
Co-developed-by: Clark Wang <xiaoning.wang@nxp.com>
Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
[fs: squashed NXP 685950f45e25, 4f7689081034; dropped enetc4_tc.c hunk
 and shared_tx_rings]
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 drivers/net/ethernet/freescale/enetc/enetc.c       | 23 ++++++++++++++++++++++
 .../net/ethernet/freescale/enetc/enetc_ethtool.c   |  1 +
 drivers/net/ethernet/freescale/enetc/enetc_hw.h    |  2 ++
 3 files changed, 26 insertions(+)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index c6571b5cc8425..4ef387578b1e4 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -3812,6 +3812,14 @@ static const struct enetc_drvdata enetc4_pf_data = {
 	.eth_ops = &enetc4_pf_ethtool_ops,
 };
 
+static const struct enetc_drvdata enetc4_6_pf_data = {
+	.sysclk_freq = ENETC_CLK_133M,
+	.tx_csum = true,
+	.max_frags = ENETC4_MAX_SKB_FRAGS,
+	.pmac_offset = ENETC4_PMAC_OFFSET,
+	.eth_ops = &enetc4_pf_ethtool_ops,
+};
+
 static const struct enetc_drvdata enetc4_ppm_data = {
 	.sysclk_freq = ENETC_CLK_333M,
 	.tx_csum = true,
@@ -3832,6 +3840,13 @@ static const struct enetc_drvdata enetc4_vf_data = {
 	.eth_ops = &enetc_vf_ethtool_ops,
 };
 
+static const struct enetc_drvdata enetc4_6_vf_data = {
+	.sysclk_freq = ENETC_CLK_133M,
+	.tx_csum = true,
+	.max_frags = ENETC4_MAX_SKB_FRAGS,
+	.eth_ops = &enetc_vf_ethtool_ops,
+};
+
 static const struct enetc_platform_info enetc_info[] = {
 	{ .revision = ENETC_REV_1_0,
 	  .dev_id = ENETC_DEV_ID_PF,
@@ -3862,6 +3877,14 @@ static const struct enetc_platform_info enetc_info[] = {
 	  .dev_id = NXP_ENETC_VF_DEV_ID,
 	  .data = &enetc4_vf_data,
 	},
+	{ .revision = ENETC_REV_4_6,
+	  .dev_id = NXP_ENETC_PF_DEV_ID,
+	  .data = &enetc4_6_pf_data,
+	},
+	{ .revision = ENETC_REV_4_6,
+	  .dev_id = NXP_ENETC_VF_DEV_ID,
+	  .data = &enetc4_6_vf_data,
+	},
 };
 
 int enetc_get_driver_data(struct enetc_si *si)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
index 7965dfd06f5f6..3c6c6fc0ab8cf 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
@@ -1149,6 +1149,7 @@ static int enetc_get_phc_index_by_pdev(struct enetc_si *si)
 		devfn = PCI_DEVFN(24, 0);
 		break;
 	case ENETC_REV_4_3:
+	case ENETC_REV_4_6:
 		devfn = PCI_DEVFN(0, 1);
 		break;
 	default:
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_hw.h b/drivers/net/ethernet/freescale/enetc/enetc_hw.h
index 2c9d9042eb0bb..339691cdf44fb 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_hw.h
+++ b/drivers/net/ethernet/freescale/enetc/enetc_hw.h
@@ -414,6 +414,7 @@ enum enetc_bdr_type {TX, RX};
 #define ENETC_REV_1_0		0x0100
 #define ENETC_REV_4_1		0X0401
 #define ENETC_REV_4_3		0x0403
+#define ENETC_REV_4_6		0x0406
 
 #define ENETC_G_EIPBRR1		0x0bfc
 #define ENETC_G_EPFBLPR(n)	(0xd00 + 4 * (n))
@@ -1050,6 +1051,7 @@ struct enetc_cbd {
 
 #define ENETC_CLK_400M		400000000ULL
 #define ENETC_CLK_333M		333000000ULL
+#define ENETC_CLK_133M		133000000ULL
 
 static inline u32 enetc_cycles_to_usecs(u32 cycles, u64 clk_freq)
 {

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH net-next 4/4] ptp: netc: use 133 MHz system clock on i.MX952
  2026-11-18 10:37 [PATCH net-next 0/4] net: enetc: Add i.MX952 support Frieder Schrempf
                   ` (2 preceding siblings ...)
  2026-11-18 10:37 ` [PATCH net-next 3/4] net: enetc: add i.MX952 ENETC support Frieder Schrempf
@ 2026-11-18 10:37 ` Frieder Schrempf
  2026-11-18 10:43 ` [PATCH net-next 0/4] net: enetc: Add i.MX952 support Clark Wang
  4 siblings, 0 replies; 11+ messages in thread
From: Frieder Schrempf @ 2026-11-18 10:37 UTC (permalink / raw)
  To: Claudiu Manoil, Vladimir Oltean, Wei Fang, Clark Wang,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Richard Cochran
  Cc: imx, netdev, devicetree, linux-kernel, Frieder Schrempf

From: Clark Wang <xiaoning.wang@nxp.com>

On i.MX952 (NETC revision 4.6) the NETC system clock runs at 133 MHz
instead of 333 MHz. If no reference clock is given in the device tree,
the timer uses the system clock, so its default frequency must match,
otherwise the PTP clock runs at the wrong rate.

The revision is read before the device tree is parsed, so it can be
used to select the default frequency.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
[fs: from NXP 8af062154e48]
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 drivers/ptp/ptp_netc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/ptp/ptp_netc.c b/drivers/ptp/ptp_netc.c
index 1a327a7561e39..7b9c0a4cbb4c3 100644
--- a/drivers/ptp/ptp_netc.c
+++ b/drivers/ptp/ptp_netc.c
@@ -72,6 +72,7 @@
 #define NETC_GLOBAL_IPBRR0		0xbf8
 #define  IPBRR0_IP_REV			GENMASK(15, 0)
 #define NETC_REV_4_1			0x0401
+#define NETC_REV_4_6			0x0406
 
 #define NETC_TMR_FIPER_NUM		3
 #define NETC_TMR_INVALID_CHANNEL	NETC_TMR_FIPER_NUM
@@ -88,6 +89,7 @@
 #define NETC_TMR_EXT_OSC		2 /* tmr_1588_clk, from IO pins */
 
 #define NETC_TMR_SYSCLK_333M		333333333U
+#define NETC_TMR_SYSCLK_133M		133333333U
 
 enum netc_pp_type {
 	NETC_PP_PPS = 1,
@@ -858,7 +860,10 @@ static int netc_timer_get_reference_clk_source(struct netc_timer *priv)
 
 	/* Select NETC system clock as the reference clock by default */
 	priv->clk_select = NETC_TMR_SYSTEM_CLK;
-	priv->clk_freq = NETC_TMR_SYSCLK_333M;
+	if (priv->revision == NETC_REV_4_6)
+		priv->clk_freq = NETC_TMR_SYSCLK_133M;
+	else
+		priv->clk_freq = NETC_TMR_SYSCLK_333M;
 
 	/* Update the clock source of the reference clock if the clock
 	 * is specified in DT node.

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* RE: [PATCH net-next 0/4] net: enetc: Add i.MX952 support
  2026-11-18 10:37 [PATCH net-next 0/4] net: enetc: Add i.MX952 support Frieder Schrempf
                   ` (3 preceding siblings ...)
  2026-11-18 10:37 ` [PATCH net-next 4/4] ptp: netc: use 133 MHz system clock on i.MX952 Frieder Schrempf
@ 2026-11-18 10:43 ` Clark Wang
  2026-11-18 10:50   ` Frieder Schrempf
  4 siblings, 1 reply; 11+ messages in thread
From: Clark Wang @ 2026-11-18 10:43 UTC (permalink / raw)
  To: Frieder Schrempf, Claudiu Manoil, Vladimir Oltean, Wei Fang,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Richard Cochran
  Cc: imx@lists.linux.dev, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Frieder Schrempf

> Subject: [PATCH net-next 0/4] net: enetc: Add i.MX952 support
> 
> This adds support for the NETC Ethernet controller on the i.MX952 SoC.
> 
> i.MX952 has two ENETC instances (IP revision 4.6), each on its own PCIe bus.
> ENETC0 shares bus 0 with the NETC timer and the central EMDIO,
> ENETC1 sits alone on bus 1. The NETC system clock runs at 133 MHz, compared to
> 333 MHz on i.MX95.
> 
> The patches are ported from NXP's lf-6.18.y vendor kernel. The device tree
> changes for imx952.dtsi and the i.MX952 EVK will be sent separately to the i.MX
> tree.
> 
> Tested on the i.MX952 EVK with ENETC0 (RGMII): the link works, hardware
> timestamping is available and the PHC runs at the correct rate. ENETC1 is
> untested as it needs an add-on board.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> Clark Wang (2):
>       net: enetc: netc_blk_ctrl: add i.MX952 support
>       ptp: netc: use 133 MHz system clock on i.MX952
> 
> Frieder Schrempf (1):
>       dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible
> 
> Wei Fang (1):
>       net: enetc: add i.MX952 ENETC support
> 
>  .../devicetree/bindings/net/nxp,netc-blk-ctrl.yaml |  1 +
>  drivers/net/ethernet/freescale/enetc/enetc.c       | 23 +++++++
>  .../net/ethernet/freescale/enetc/enetc_ethtool.c   |  1 +
>  drivers/net/ethernet/freescale/enetc/enetc_hw.h    |  2 +
>  .../net/ethernet/freescale/enetc/netc_blk_ctrl.c   | 73
> ++++++++++++++++++++++
>  drivers/ptp/ptp_netc.c                             |  7 ++-
>  6 files changed, 106 insertions(+), 1 deletion(-)
> ---
> base-commit: d6816d9a93b66a12bf01e10037e377f3333ad6cc
> change-id: 20261118-imx952-enetc-bd2bc331e1b5
> 
> Best regards,
> --
> Frieder Schrempf <frieder.schrempf@kontron.de>

Hi Frieder,

I have sent the V1 patchset for imx952, will sent V2 this week.
https://lore.kernel.org/all/20261104092217.1730351-1-xiaoning.wang@oss.nxp.com/

Thanks!

Best Regards,
Clark Wang



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH net-next 0/4] net: enetc: Add i.MX952 support
  2026-11-18 10:43 ` [PATCH net-next 0/4] net: enetc: Add i.MX952 support Clark Wang
@ 2026-11-18 10:50   ` Frieder Schrempf
  0 siblings, 0 replies; 11+ messages in thread
From: Frieder Schrempf @ 2026-11-18 10:50 UTC (permalink / raw)
  To: Clark Wang, Frieder Schrempf, Claudiu Manoil, Vladimir Oltean,
	Wei Fang, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Richard Cochran
  Cc: imx@lists.linux.dev, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org

On 18.11.26 11:43, Clark Wang wrote:
> [Sie erhalten nicht h?ufig E-Mails von xiaoning.wang@nxp.com. Weitere Informationen, warum dies wichtig ist, finden Sie unter https://aka.ms/LearnAboutSenderIdentification ]
> 
>> Subject: [PATCH net-next 0/4] net: enetc: Add i.MX952 support
>>
>> This adds support for the NETC Ethernet controller on the i.MX952 SoC.
>>
>> i.MX952 has two ENETC instances (IP revision 4.6), each on its own PCIe bus.
>> ENETC0 shares bus 0 with the NETC timer and the central EMDIO,
>> ENETC1 sits alone on bus 1. The NETC system clock runs at 133 MHz, compared to
>> 333 MHz on i.MX95.
>>
>> The patches are ported from NXP's lf-6.18.y vendor kernel. The device tree
>> changes for imx952.dtsi and the i.MX952 EVK will be sent separately to the i.MX
>> tree.
>>
>> Tested on the i.MX952 EVK with ENETC0 (RGMII): the link works, hardware
>> timestamping is available and the PHC runs at the correct rate. ENETC1 is
>> untested as it needs an add-on board.
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ---
>> Clark Wang (2):
>>       net: enetc: netc_blk_ctrl: add i.MX952 support
>>       ptp: netc: use 133 MHz system clock on i.MX952
>>
>> Frieder Schrempf (1):
>>       dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible
>>
>> Wei Fang (1):
>>       net: enetc: add i.MX952 ENETC support
>>
>>  .../devicetree/bindings/net/nxp,netc-blk-ctrl.yaml |  1 +
>>  drivers/net/ethernet/freescale/enetc/enetc.c       | 23 +++++++
>>  .../net/ethernet/freescale/enetc/enetc_ethtool.c   |  1 +
>>  drivers/net/ethernet/freescale/enetc/enetc_hw.h    |  2 +
>>  .../net/ethernet/freescale/enetc/netc_blk_ctrl.c   | 73
>> ++++++++++++++++++++++
>>  drivers/ptp/ptp_netc.c                             |  7 ++-
>>  6 files changed, 106 insertions(+), 1 deletion(-)
>> ---
>> base-commit: d6816d9a93b66a12bf01e10037e377f3333ad6cc
>> change-id: 20261118-imx952-enetc-bd2bc331e1b5
>>
>> Best regards,
>> --
>> Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> Hi Frieder,
> 
> I have sent the V1 patchset for imx952, will sent V2 this week.
> https://lore.kernel.org/all/20261104092217.1730351-1-xiaoning.wang@oss.nxp.com/

Thanks! I totally missed your series when I was searching for it.

Please ignore this series and sorry for the additional noise.


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH net-next 2/4] net: enetc: netc_blk_ctrl: add i.MX952 support
  2026-11-18 10:37 ` [PATCH net-next 2/4] net: enetc: netc_blk_ctrl: add i.MX952 support Frieder Schrempf
@ 2026-11-18 13:51   ` Andrew Lunn
  2026-11-22 11:00   ` netdev-bot+sashiko
  1 sibling, 0 replies; 11+ messages in thread
From: Andrew Lunn @ 2026-11-18 13:51 UTC (permalink / raw)
  To: Frieder Schrempf
  Cc: Claudiu Manoil, Vladimir Oltean, Wei Fang, Clark Wang,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Richard Cochran, imx, netdev, devicetree, linux-kernel,
	Frieder Schrempf

> +static int imx952_netcmix_init(struct platform_device *pdev)
> +{
> +	struct netc_blk_ctrl *priv = platform_get_drvdata(pdev);
> +	struct device_node *np = pdev->dev.of_node;
> +	phy_interface_t interface;
> +	int bus_devfn, mii_proto;
> +	u32 val;
> +	int err;
> +
> +	/* Default setting */
> +	val = MII_PROT(0, MII_PROT_RGMII) | MII_PROT(1, MII_PROT_RGMII);
> +
> +	/* Update the link MII protocol through parsing phy-mode */
> +	for_each_child_of_node_scoped(np, child) {
> +		for_each_child_of_node_scoped(child, gchild) {
> +			if (!of_device_is_compatible(gchild, "pci1131,e101"))
> +				continue;
> +
> +			bus_devfn = netc_of_pci_get_bus_devfn(gchild);
> +			if (bus_devfn < 0)
> +				return bus_devfn;
> +
> +			err = of_get_phy_mode(gchild, &interface);
> +			if (err)
> +				continue;
> +
> +			mii_proto = netc_get_link_mii_protocol(interface);
> +			if (mii_proto < 0)
> +				return mii_proto;
> +
> +			switch (bus_devfn) {
> +			case IMX952_ENETC0_BUS_DEVFN:
> +				val = u32_replace_bits(val, mii_proto,
> +						       CFG_LINK_MII_PORT_0);
> +				break;
> +			case IMX952_ENETC1_BUS_DEVFN:
> +				val = u32_replace_bits(val, mii_proto,
> +						       CFG_LINK_MII_PORT_1);
> +				break;
> +			default:
> +				return -EINVAL;
> +			}
> +		}
> +	}
> +
> +	netc_reg_write(priv->netcmix, IMX95_CFG_LINK_MII_PROT, val);
> +
> +	return 0;
> +}
> +

This looks very similar to imx95_netcmix_init(), and
imx94_link_config() is similar to the core of this loop.

Can some core refactoring be done to reduce duplication?

Andrew

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH net-next 1/4] dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible
  2026-11-18 10:37 ` [PATCH net-next 1/4] dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible Frieder Schrempf
@ 2026-11-18 17:43   ` Conor Dooley
  0 siblings, 0 replies; 11+ messages in thread
From: Conor Dooley @ 2026-11-18 17:43 UTC (permalink / raw)
  To: Frieder Schrempf
  Cc: Claudiu Manoil, Vladimir Oltean, Wei Fang, Clark Wang,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Richard Cochran, imx, netdev, devicetree, linux-kernel,
	Frieder Schrempf

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH net-next 2/4] net: enetc: netc_blk_ctrl: add i.MX952 support
  2026-11-18 10:37 ` [PATCH net-next 2/4] net: enetc: netc_blk_ctrl: add i.MX952 support Frieder Schrempf
  2026-11-18 13:51   ` Andrew Lunn
@ 2026-11-22 11:00   ` netdev-bot+sashiko
  1 sibling, 0 replies; 11+ messages in thread
From: netdev-bot+sashiko @ 2026-11-22 11:00 UTC (permalink / raw)
  To: frieder
  Cc: claudiu.manoil, vladimir.oltean, wei.fang, xiaoning.wang,
	andrew+netdev, davem, edumazet, kuba, pabeni, robh, krzk+dt,
	conor+dt, richardcochran, imx, netdev, devicetree, linux-kernel,
	frieder.schrempf

Thank you for your contribution! Sashiko AI review found 3 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 2 · Low: 1

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] imx952_ierb_init()
  (drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c) writes only…
- [Medium] imx952_netcmix_init()
  (drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c) accepts serial…
- [Low] imx952_ierb_init() writes the hard-coded IMX952_BYTE_CREDIT
  (0xc35 = 3125 bytes) to E0TXHPTBCR/E0TXLPTBCR.

--

net: enetc: netc_blk_ctrl: add i.MX952 support

This patch adds NETCMIX support for i.MX952, which has two ENETC
instances on separate PCIe buses. Their link MII protocol is configured
through the IMX95_CFG_LINK_MII_PROT register. During IERB init it also
sets the ENETC0 TX byte-credit registers to 0xc35.

> diff --git a/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c b/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
> index 658fab31e9ed7..6e3098a0a43ee 100644
> --- a/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
> +++ b/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c

[ ... ]

> @@ -368,6 +374,56 @@ static int imx94_netcmix_init(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static int imx952_netcmix_init(struct platform_device *pdev)
> +{

[ ... ]

> +			mii_proto = netc_get_link_mii_protocol(interface);
> +			if (mii_proto < 0)
> +				return mii_proto;
> +
> +			switch (bus_devfn) {
> +			case IMX952_ENETC0_BUS_DEVFN:
> +				val = u32_replace_bits(val, mii_proto,
> +						       CFG_LINK_MII_PORT_0);
> +				break;
> +			case IMX952_ENETC1_BUS_DEVFN:
> +				val = u32_replace_bits(val, mii_proto,
> +						       CFG_LINK_MII_PORT_1);
> +				break;
> +			default:
> +				return -EINVAL;
> +			}
> +		}
> +	}
> +
> +	netc_reg_write(priv->netcmix, IMX95_CFG_LINK_MII_PROT, val);

[Severity: Medium]
Does this leave serial links only partly configured?

netc_get_link_mii_protocol() maps sgmii, 2500base-x, 10gbase-r, xgmii and
usxgmii to MII_PROT_SERIAL, and that value gets written into
CFG_LINK_MII_PORT_n here. However, IMX95_CFG_LINK_IO_VAR and
IMX95_CFG_LINK_PCS_PROT(n) are never written, and serial modes are not
rejected either.

imx95_netcmix_init() sets these registers together for its serial link:

	/* Configure Link I/O variant */
	netc_reg_write(priv->netcmix, IMX95_CFG_LINK_IO_VAR,
		       IO_VAR(2, IO_VAR_16FF_16G_SERDES));
	/* Configure Link 2 PCS protocol */
	netc_reg_write(priv->netcmix, IMX95_CFG_LINK_PCS_PROT(2),
		       PCS_PROT_10G_SXGMII);

imx94_link_config() also sets NETC_LINK_CFG_IO_VAR whenever the protocol
is MII_PROT_SERIAL.

The patch "net: enetc: add i.MX952 ENETC support" in this series says
133 MHz is needed as the ENETC sysclk "to enable SGMII 1G". That makes
SGMII look like a supported configuration on i.MX952.

Take an i.MX952 ENETC with phy-mode = "sgmii". Would the MAC be switched
to the serial datapath while the I/O variant and PCS protocol keep their
reset or bootloader values? If so, the link would never come up even
though probe succeeds.

> +
> +	return 0;
> +}

[ ... ]

> @@ -783,6 +839,16 @@ static int imx94_ierb_init(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static int imx952_ierb_init(struct platform_device *pdev)
> +{
> +	struct netc_blk_ctrl *priv = platform_get_drvdata(pdev);
> +
> +	netc_reg_write(priv->ierb, IERB_ETXHPTBCR(0), IMX952_BYTE_CREDIT);
> +	netc_reg_write(priv->ierb, IERB_ETXLPTBCR(0), IMX952_BYTE_CREDIT);

[Severity: Low]
How was IMX952_BYTE_CREDIT (0xc35, or 3125 bytes) derived?

The commit message says:

  Both ENETC0 transmit byte-credit registers reset to 0x5dc, which
  matches the RM example for a 1536-byte maximum frame size.

0x5dc is 1500, and 1536 would be 0x600. Is the arithmetic in the commit
message correct?

The commit message also links the problem to jumbo frames. However, 3125
has no clear relation to ENETC_MAC_MAXFRM_SIZE (9600), which enetc4_pf.c
programs into PM_MAXFRM. The only reason given for the value is "the
same as port 1".

For comparison, the LS1028A code in enetc_ierb.c derives its TX credit
from the maximum frame size:

	tx_credit = roundup(1000 + ENETC_MAC_MAXFRM_SIZE / 2, 100);

Suppose the i.MX952 credit needs to cover at least one maximum-size
frame. Would 3125 bytes still throttle ENETC0 jumbo TX?

These registers cannot be changed once the IERB is locked. Could the RM
rule be documented here, or the value derived from ENETC_MAC_MAXFRM_SIZE?

Writing the value unconditionally seems fine, though. "ptp: netc: use
133 MHz system clock on i.MX952" in this series says the i.MX952 NETC
system clock is 133 MHz.

> +
> +	return 0;
> +}

[Severity: Medium]
Should imx952_ierb_init() also program the port EMDIO PHY address into
IERB_LBCR(n) for each ENETC?

Both sibling SoCs do this in their ierb_init callbacks: i.MX95 through
imx95_enetc_mdio_phyaddr_config() and i.MX94 through
imx94_enetc_mdio_phyaddr_config(). The i.MX95 version says:

	/* Update the port EMDIO PHY address through parsing phy properties.
	 * This is needed when using the port EMDIO but it's harmless when
	 * using the central EMDIO. So apply it on all cases.
	 */

Those functions also check the PHY addresses against the central EMDIO
mask from netc_get_emdio_phy_mask(). That check is missing here too.

netc_ierb_init() calls netc_lock_ierb() as soon as devinfo->ierb_init()
returns, so LBCR cannot be corrected later. Meanwhile,
enetc_mdiobus_create() still creates a port MDIO bus whenever the ENETC
node has an "mdio" child:

	mdio_np = of_get_child_by_name(node, "mdio");
	if (mdio_np) {
		err = enetc_mdio_probe(pf, mdio_np);

On an i.MX952 board that uses port MDIO, would that bus stay at the
reset-default PHY address instead of the PHY described in DT? That would
make the PHY probe or the link fail. A PHY address that clashes with the
central EMDIO would also go undetected.

The dt-bindings patch in this series describes the i.MX952 IERB block as
the same as on i.MX95. No later patch in the series touches
netc_blk_ctrl.c.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118-imx952-enetc-v1-0-25721440602e%40kontron.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH net-next 3/4] net: enetc: add i.MX952 ENETC support
  2026-11-18 10:37 ` [PATCH net-next 3/4] net: enetc: add i.MX952 ENETC support Frieder Schrempf
@ 2026-11-22 11:00   ` netdev-bot+sashiko
  0 siblings, 0 replies; 11+ messages in thread
From: netdev-bot+sashiko @ 2026-11-22 11:00 UTC (permalink / raw)
  To: frieder
  Cc: claudiu.manoil, vladimir.oltean, wei.fang, xiaoning.wang,
	andrew+netdev, davem, edumazet, kuba, pabeni, robh, krzk+dt,
	conor+dt, richardcochran, imx, netdev, devicetree, linux-kernel,
	frieder.schrempf

Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 2 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] When an i.MX952 (ENETC rev 4.6) VF cannot get its IP minor
  revision from the PF, enetc_vf_get_revision()…
- [Medium] This finding is speculative.

--

net: enetc: add i.MX952 ENETC support

This commit adds ENETC revision 4.6 (i.MX952) entries to the enetc_info
table, with new PF and VF driver data that use a 133 MHz sysclk. It also
maps revision 4.6 to a PTP timer at PCI_DEVFN(0, 1) in
enetc_get_phc_index_by_pdev().

> diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
> index c6571b5cc8425..4ef387578b1e4 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc.c

[ ... ]

> @@ -3832,6 +3840,13 @@ static const struct enetc_drvdata enetc4_vf_data = {
>  	.eth_ops = &enetc_vf_ethtool_ops,
>  };
>  
> +static const struct enetc_drvdata enetc4_6_vf_data = {
> +	.sysclk_freq = ENETC_CLK_133M,
> +	.tx_csum = true,
> +	.max_frags = ENETC4_MAX_SKB_FRAGS,
> +	.eth_ops = &enetc_vf_ethtool_ops,
> +};
> +

[Severity: Medium]
What happens to an i.MX952 VF when it cannot get the minor revision from
the PF? enetc_vf_get_revision() in enetc_vf.c falls back to a fixed
revision:

drivers/net/ethernet/freescale/enetc/enetc_vf.c:enetc_vf_get_revision() {
    ...
	ip_mn = enetc_vf_get_ip_minor_revision(si);
	if (ip_mn >= 0) {
		si->revision = (si->pdev->revision << 8) | ip_mn;
		return;
	}

	si->revision = ENETC_REV_4_1;
    ...
}

In that case enetc_get_driver_data() matches the ENETC_REV_4_1 VF entry.
It selects enetc4_vf_data (333 MHz) instead of enetc4_6_vf_data
(133 MHz), and enetc_vf_netdev_setup() copies the 333 MHz value into
priv->sysclk_freq.

Before this patch every v4 VF drvdata used 333 MHz, so the fallback still
gave the right clock. Now that rev 4.6 uses a different sysclk, would
every usec/cycle conversion on that VF be off by about 2.5x?

For example, enetc_init_si_rings_params() does:

	priv->tx_ictt = enetc_usecs_to_cycles(600, priv->sysclk_freq);

At the real 133 MHz clock this works out to about 1.5 ms instead of
600 us. The RX DIM work and the ethtool coalesce get/set paths would be
scaled by the same wrong factor.

The fallback also makes enetc_get_phc_index_by_pdev() take the
ENETC_REV_4_1 case. That case looks up the timer at PCI_DEVFN(24, 0), not
at the PCI_DEVFN(0, 1) added below for rev 4.6. Without a ptp-timer
phandle, could the VF then report no PHC, or the wrong one?

The fallback runs whenever enetc_vf_get_ip_minor_revision() returns an
error. That can be a DMA allocation failure, a busy mailbox, a poll
timeout, or an error status from the PF.

>  static const struct enetc_platform_info enetc_info[] = {
>  	{ .revision = ENETC_REV_1_0,
>  	  .dev_id = ENETC_DEV_ID_PF,

[ ... ]

> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
> index 7965dfd06f5f6..3c6c6fc0ab8cf 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
> @@ -1149,6 +1149,7 @@ static int enetc_get_phc_index_by_pdev(struct enetc_si *si)
>  		devfn = PCI_DEVFN(24, 0);
>  		break;
>  	case ENETC_REV_4_3:
> +	case ENETC_REV_4_6:
>  		devfn = PCI_DEVFN(0, 1);
>  		break;

[Severity: Medium]
Is there a NETC timer at 00.1 on the bus of each i.MX952 ENETC?

netc_blk_ctrl.c puts the two i.MX952 ENETCs on different buses:

#define IMX952_ENETC0_BUS_DEVFN		0x0
#define IMX952_ENETC1_BUS_DEVFN		0x100

This lookup uses the ENETC's own bus->number. So ENETC0 would look for a
timer at 00:00.1, and ENETC1 would look for one at 01:00.1.

i.MX94 has a timer at 00.1 on each bus. It also programs the
ENETC-to-timer binding explicitly in imx94_enetc_update_tid():

	netc_reg_write(priv->ierb, IERB_ETBCR(eid), tid);

imx952_ierb_init() only writes the byte credit registers and never
programs IERB_ETBCR. There are also no i.MX952 timer definitions or NETC
DT nodes in the tree to compare against, so I couldn't verify the
topology. This may well be fine on real hardware.

If only one timer exists, would the ENETC on the other bus get -1 here
and report no PHC?

If each bus has its own timer, but the reset value of IERB_ETBCR does not
bind each ENETC to the timer on its own bus, could the PHC index reported
to userspace differ from the timer that actually timestamps the packets?

>  	default:

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118-imx952-enetc-v1-0-25721440602e%40kontron.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2026-11-22 11:00 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 10:37 [PATCH net-next 0/4] net: enetc: Add i.MX952 support Frieder Schrempf
2026-11-18 10:37 ` [PATCH net-next 1/4] dt-bindings: net: nxp,netc-blk-ctrl: add i.MX952 compatible Frieder Schrempf
2026-11-18 17:43   ` Conor Dooley
2026-11-18 10:37 ` [PATCH net-next 2/4] net: enetc: netc_blk_ctrl: add i.MX952 support Frieder Schrempf
2026-11-18 13:51   ` Andrew Lunn
2026-11-22 11:00   ` netdev-bot+sashiko
2026-11-18 10:37 ` [PATCH net-next 3/4] net: enetc: add i.MX952 ENETC support Frieder Schrempf
2026-11-22 11:00   ` netdev-bot+sashiko
2026-11-18 10:37 ` [PATCH net-next 4/4] ptp: netc: use 133 MHz system clock on i.MX952 Frieder Schrempf
2026-11-18 10:43 ` [PATCH net-next 0/4] net: enetc: Add i.MX952 support Clark Wang
2026-11-18 10:50   ` Frieder Schrempf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox