* pktgen multiqueue oops
@ 2007-08-27 9:16 Robert Olsson
0 siblings, 0 replies; only message in thread
From: Robert Olsson @ 2007-08-27 9:16 UTC (permalink / raw)
To: David Miller; +Cc: Robert.Olsson, netdev
Hello,
Initially pkt_dev can be NULL this causes netif_subqueue_stopped to
oops. The patch below should cure it. But maybe the pktgen TX logic
should be reworked to better support the new multiqueue support.
Cheers
--ro
Signed-off-by: Robert Olsson <robert.olsson@its.uu.se>
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 7bae576..a0db4d1 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3331,8 +3331,9 @@ static __inline__ void pktgen_xmit(struct pktgen_dev *pkt_dev)
}
if ((netif_queue_stopped(odev) ||
- netif_subqueue_stopped(odev, pkt_dev->skb->queue_mapping)) ||
- need_resched()) {
+ (pkt_dev->skb &&
+ netif_subqueue_stopped(odev, pkt_dev->skb->queue_mapping))) ||
+ need_resched()) {
idle_start = getCurUs();
if (!netif_running(odev)) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-27 9:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-27 9:16 pktgen multiqueue oops Robert Olsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox