From: Ivan Vecera <ivecera@redhat.com>
To: Petr Oros <poros@redhat.com>, netdev@vger.kernel.org
Cc: dsahern@kernel.org, stephen@networkplumber.org, vgrinber@redhat.com
Subject: Re: [PATCH iproute2-next 1/2] dpll: align help and man notation with actual option parsing
Date: Tue, 12 May 2026 17:25:58 +0200 [thread overview]
Message-ID: <18ca4ef1-3ba0-4a43-8070-844fc6713be1@redhat.com> (raw)
In-Reply-To: <20260512135225.167158-1-poros@redhat.com>
On 5/12/26 3:52 PM, Petr Oros wrote:
> dpll uses getopt_long(), which only accepts long options with the
> "--" prefix. The iproute2-wide "-X[name]" shorthand used in the
> help text and man page implies a single-dash long form
> (e.g. -Version, -json, -pretty) that getopt_long does not parse;
> only -V/--Version, -j/--json and -p/--pretty actually work.
>
> Replace the misleading shorthand with explicit "-V | --Version"
> style so the documented forms match what the parser accepts, and
> drop the redundant second usage line in help() that listed only a
> subset of the options and implied dpll could be invoked without an
> OBJECT. No functional change.
>
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---
> dpll/dpll.c | 3 +--
> man/man8/dpll.8 | 12 ++++++------
> 2 files changed, 7 insertions(+), 8 deletions(-)
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
prev parent reply other threads:[~2026-05-12 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 13:52 [PATCH iproute2-next 1/2] dpll: align help and man notation with actual option parsing Petr Oros
2026-05-12 13:52 ` [PATCH iproute2-next 2/2] dpll: monitor: add -t/--timestamp and --tshort options Petr Oros
2026-05-12 15:26 ` Ivan Vecera
2026-05-12 15:25 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ca4ef1-3ba0-4a43-8070-844fc6713be1@redhat.com \
--to=ivecera@redhat.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=poros@redhat.com \
--cc=stephen@networkplumber.org \
--cc=vgrinber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox