Re: [PATCH iproute2-next 2/2] dpll: monitor: add -t/--timestamp and --tshort options

[Ivan Vecera <ivecera@redhat.com>]

On 5/12/26 3:52 PM, Petr Oros wrote:
> Bring dpll monitor in line with the rest of iproute2 by allowing each
> received notification to be prefixed with a wall-clock timestamp.
> 
>    -t / --timestamp  emit a separate "Timestamp:" line before each event,
>                      using the default text form of print_timestamp()
>                      (matches ip / bridge / tc -t monitor)
>    --tshort          emit a compact ISO 8601 prefix
>                      "[YYYY-MM-DDTHH:MM:SS.uuuuuu]" inline instead
>                      (matches ip -ts monitor)
> 
> When combined with -j, the timestamp shows up as a "timestamp" /
> "timestamp_short" field on each notification object, the same way
> ip -j -t mptcp monitor integrates the helper.
> 
> The flag is parsed globally but only consulted from the monitor
> callback, so passing -t to non-monitor commands is a no-op.
> 
> --tshort has no short alias, so its long_options entry uses an
> identifier above the ASCII range (OPT_TSHORT = 256) following the
> iproute2 convention used in misc/ss.c, instead of consuming an
> ASCII letter that could later collide with a real short option.
> 
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---
>   bash-completion/dpll |  8 ++++++--
>   dpll/dpll.c          | 21 +++++++++++++++++++--
>   man/man8/dpll.8      | 23 ++++++++++++++++++++++-
>   3 files changed, 47 insertions(+), 5 deletions(-)
> 

Reviewed-by: Ivan Vecera <ivecera@redhat.com>