From: Jay Vosburgh <jv@jvosburgh.net>
To: David Wilder <wilder@us.ibm.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"pradeeps@linux.vnet.ibm.com" <pradeeps@linux.vnet.ibm.com>,
Pradeep Satyanarayana <pradeep@us.ibm.com>,
"i.maximets@ovn.org" <i.maximets@ovn.org>,
Adrian Moreno Zapata <amorenoz@redhat.com>,
Hangbin Liu <haliu@redhat.com>
Subject: Re: [PATCH net-next v3 2/4] bonding: Extend arp_ip_target format to allow for a list of vlan tags.
Date: Tue, 17 Jun 2025 09:06:33 -0700 [thread overview]
Message-ID: <1969718.1750176393@famine> (raw)
In-Reply-To: <MW3PR15MB3913A782BBBCFEC112E1A662FA73A@MW3PR15MB3913.namprd15.prod.outlook.com>
David Wilder <wilder@us.ibm.com> wrote:
>
>
>> Here, and further down in bond_arp_ip_target_opt_parse(),
>>there's a lot of string handling that seems out place. Why isn't the
>>string parsing done in user space (iproute, et al), and the tags passed
>>to the kernel in IFLA_BOND_ARP_IP_TARGET as an optional nested
>>attribute?
>
>>>+ }
>
>> There is no expectation that sysfs should support new bonding
>>API elements; only netlink / iproute2 support matters. If sysfs is the
>>reason to do the string parsing in the kernel, then I imagine this could
>>all move into userspace.
>>
>> -J
>
>Module parameter support also requires string parsing in the kernel. Can that be dropped as well?
Yes. New bonding functionality need not be supported by sysfs
or module parameters.
-J
---
-Jay Vosburgh, jv@jvosburgh.net
next prev parent reply other threads:[~2025-06-17 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 1:48 [PATCH net-next v3 0/4] bonding: Extend arp_ip_target format to allow for a list of vlan tags David Wilder
2025-06-14 1:48 ` [PATCH net-next v3 1/4] bonding: Adding struct bond_arp_target David Wilder
2025-06-14 1:48 ` [PATCH net-next v3 2/4] bonding: Extend arp_ip_target format to allow for a list of vlan tags David Wilder
2025-06-15 5:42 ` kernel test robot
2025-06-16 23:15 ` Jay Vosburgh
2025-06-17 15:45 ` David Wilder
2025-06-17 16:06 ` Jay Vosburgh [this message]
2025-06-14 1:48 ` [PATCH net-next v3 3/4] bonding: Selftest for the arp_ip_target parameter David Wilder
2025-06-14 1:48 ` [PATCH net-next v3 4/4] bonding: Update to the bonding documentation David Wilder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1969718.1750176393@famine \
--to=jv@jvosburgh.net \
--cc=amorenoz@redhat.com \
--cc=haliu@redhat.com \
--cc=i.maximets@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pradeep@us.ibm.com \
--cc=pradeeps@linux.vnet.ibm.com \
--cc=wilder@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox