From: Ferenc Fejes <fejes@inf.elte.hu>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David Ahern" <dsahern@kernel.org>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Péter Antal" <antal.peti99@gmail.com>
Subject: Re: [PATCH iproute2-next 0/9] Add tc-mqprio and tc-taprio support for preemptible traffic classes
Date: Mon, 03 Apr 2023 13:30:06 +0200 [thread overview]
Message-ID: <1998a6a01c5f1905f0f4e1e72d4e19500fc352d1.camel@inf.elte.hu> (raw)
In-Reply-To: <20230403112348.patphgia5en6v2ec@skbuf>
Hi Vladimir!
On Mon, 2023-04-03 at 14:23 +0300, Vladimir Oltean wrote:
> Hi Ferenc,
>
> On Mon, Apr 03, 2023 at 01:18:07PM +0200, Ferenc Fejes wrote:
> > Seems like Stephen merged Péter's manpages patch [1] but IMO your
> > version [2] is a better overhaul of that, also Péter ACK-ed to go
> > forward with that version. Looks like you rebased this work on the
> > new
> > manpages, you have any plan to submit the changes from [2]
> > separately?
> > Probably Stephen missed the whole discussion and about [2] and I'm
> > admit that putting acked/reviewed into a mail inside the discussion
> > might be misleading (probably thats show up for the original patch
> > in
> > patchwork). Sorry for making it complicated.
> > [1]
> > https://lore.kernel.org/netdev/167789641838.26474.2747633103367439718.git-patchwork-notify@kernel.org/
> >
> > [2]
> > https://lore.kernel.org/netdev/20230220161809.t2vj6daixio7uzbw@skbuf/
>
> Yes, this is true. I still have the delta between Péter's merged
> version
> and my suggested changes, but it needs to be broken up into a
> gazillion
> smaller patches which I haven't done yet. I now also doubt the value
> of
> some of those changes as standalone patches. I wanted to get the
> preemption
> stuff over with first, and this is why I've submitted only what I
> have.
Understandable, thanks for the info. With all respect of your time, it
would be nice if those changes make their way into the manpages in one
way or another. I think it has enough value in its own too, but I agree
it has much lower prio than having FP merged and running :-)
Ferenc
prev parent reply other threads:[~2023-04-03 11:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 10:52 [PATCH iproute2-next 0/9] Add tc-mqprio and tc-taprio support for preemptible traffic classes Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 1/9] uapi: add definitions for preemptible traffic classes in mqprio and taprio Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 2/9] utils: add max() definition Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 3/9] tc/taprio: add max-sdu to the man page SYNOPSIS section Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 4/9] tc/taprio: add a size table to the examples from the man page Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 5/9] tc/mqprio: fix stray ] in man page synopsis Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 6/9] tc/mqprio: use words in man page to express min_rate/max_rate dependency on bw_rlimit Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 7/9] tc/mqprio: break up synopsis into multiple lines Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 8/9] tc/mqprio: add support for preemptible traffic classes Vladimir Oltean
2023-04-03 10:52 ` [PATCH iproute2-next 9/9] tc/taprio: " Vladimir Oltean
2023-04-03 11:18 ` [PATCH iproute2-next 0/9] Add tc-mqprio and tc-taprio " Ferenc Fejes
2023-04-03 11:23 ` Vladimir Oltean
2023-04-03 11:30 ` Ferenc Fejes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1998a6a01c5f1905f0f4e1e72d4e19500fc352d1.camel@inf.elte.hu \
--to=fejes@inf.elte.hu \
--cc=antal.peti99@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox