Netdev List
 help / color / mirror / Atom feed
From: Quentin Monnet <quentin.monnet@netronome.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	oss-drivers@netronome.com, Jiri Pirko <jiri@resnulli.us>,
	Alexander Aring <aring@mojatatu.com>
Subject: Re: [PATCH net-next] net: sched: fix tcf_block_get_ext() in case CONFIG_NET_CLS is not set
Date: Thu, 4 Jan 2018 09:59:57 +0000	[thread overview]
Message-ID: <1d6a9fe2-f1e2-116e-3f39-e81877db4cf3@netronome.com> (raw)
In-Reply-To: <CAM_iQpUYQgnRjry2=V4titjFEuehN5zo2NWidZU_OEuLUCJXyA@mail.gmail.com>

Hi Cong,

2018-01-03 18:08 UTC-0800 ~ Cong Wang <xiyou.wangcong@gmail.com>
> On Wed, Jan 3, 2018 at 5:30 PM, Jakub Kicinski
> <jakub.kicinski@netronome.com> wrote:
>> From: Quentin Monnet <quentin.monnet@netronome.com>
>>
>> The definition of functions tcf_block_get() and tcf_block_get_ext()
>> depends of CONFIG_NET_CLS being set. When those functions gained extack
>> support, only one version of the declaration of those functions was
>> updated. Function tcf_block_get() was later fixed with commit
>> 3c1490913f3b ("net: sch: api: fix tcf_block_get").
>>
>> Change arguments of tcf_block_get_ext() for the case when CONFIG_NET_CLS
>> is not set.
> 
> There is one already:
> https://patchwork.kernel.org/patch/10130849/
> 

Thanks! But this patch is the one I mentioned in the commit log: it
fixes a different function, tcf_block_get(). My patch is an additional
fix for tcf_block_get_ext().

Best regards,
Quentin

  reply	other threads:[~2018-01-04 10:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04  1:30 [PATCH net-next] net: sched: fix tcf_block_get_ext() in case CONFIG_NET_CLS is not set Jakub Kicinski
2018-01-04  2:08 ` Cong Wang
2018-01-04  9:59   ` Quentin Monnet [this message]
2018-01-04 23:22     ` Cong Wang
2018-01-05 16:18 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d6a9fe2-f1e2-116e-3f39-e81877db4cf3@netronome.com \
    --to=quentin.monnet@netronome.com \
    --cc=aring@mojatatu.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox