Netdev List
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linaro-kernel@lists.linaro.org
Cc: Mark Brown <broonie@kernel.org>, Chien Yen <chien.yen@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, rds-devel@oss.oracle.com,
	Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] net: rds: Don't allocate rds_sock on stack
Date: Mon, 25 Aug 2014 13:33:33 +0200	[thread overview]
Message-ID: <2003093.xT3MtFJFAa@wuerfel> (raw)
In-Reply-To: <1408926755-12277-1-git-send-email-broonie@kernel.org>

On Sunday 24 August 2014 19:32:35 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> struct rds_sock is rather large ausing the following warning in an ARM
> allmodconfig:
> 
> net/rds/iw_rdma.c:200:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 
> Fix this by dynamically allocating struct rds_sock in rds_iw_update_cm_id
> instead of allocating it on the stack.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

  reply	other threads:[~2014-08-25 11:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25  0:32 [PATCH] net: rds: Don't allocate rds_sock on stack Mark Brown
2014-08-25 11:33 ` Arnd Bergmann [this message]
2014-08-25 19:57 ` David Miller
2014-08-26  6:54   ` Mark Brown
2014-08-26 15:29     ` David Miller
2014-08-27 10:46       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2003093.xT3MtFJFAa@wuerfel \
    --to=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=broonie@linaro.org \
    --cc=chien.yen@oracle.com \
    --cc=davem@davemloft.net \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox