From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: herbert@gondor.apana.org.au
Cc: christophe@saout.de, linux-net@vger.kernel.org,
netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets
Date: Sun, 22 May 2005 05:18:17 +0900 (JST) [thread overview]
Message-ID: <20050522.051817.122678688.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <20050521194932.GA10959@gondor.apana.org.au>
In article <20050521194932.GA10959@gondor.apana.org.au> (at Sun, 22 May 2005 05:49:32 +1000), Herbert Xu <herbert@gondor.apana.org.au> says:
> On Sat, May 21, 2005 at 07:10:11PM +0000, Christophe Saout wrote:
> >
> > The oops occurs in line 391 in net/ipv6/icmp.c:
> >
> > > idev = in6_dev_get(skb->dev);
>
> Here is a minimal fix.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> BTW, icmpv6_send seems to ignore its dev argument altogether.
> Any reason why we can't just use it instead of skb->dev?
(After looking into icmpv6_send() usages,)
I don't know the reason why we needed the last argument "dev".
It seems that we already had it at the time of 2.2.16.
Probably, we can remove it.
--yoshfuji
next prev parent reply other threads:[~2005-05-21 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1116702611.14509.10.camel@leto.cs.pocnet.net>
2005-05-21 19:49 ` [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets Herbert Xu
2005-05-21 20:18 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2005-05-22 7:34 ` Herbert Xu
2005-05-23 20:11 ` David S. Miller
2005-05-21 21:49 ` Christophe Saout
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050522.051817.122678688.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=christophe@saout.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox