From: Herbert Xu <herbert@gondor.apana.org.au>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: christophe@saout.de, linux-net@vger.kernel.org,
netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets
Date: Sun, 22 May 2005 17:34:35 +1000 [thread overview]
Message-ID: <20050522073435.GA15867@gondor.apana.org.au> (raw)
In-Reply-To: <20050522.051817.122678688.yoshfuji@linux-ipv6.org>
On Sun, May 22, 2005 at 05:18:17AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
>
> > BTW, icmpv6_send seems to ignore its dev argument altogether.
> > Any reason why we can't just use it instead of skb->dev?
>
> (After looking into icmpv6_send() usages,)
> I don't know the reason why we needed the last argument "dev".
> It seems that we already had it at the time of 2.2.16.
> Probably, we can remove it.
In a number of places (I've just created another one with my patch :)
we are setting skb->dev specifically for icmpv6_send. If we make
icmpv6_send use its dev argument instead of skb->dev then we can
avoid those settings.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2005-05-22 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1116702611.14509.10.camel@leto.cs.pocnet.net>
2005-05-21 19:49 ` [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets Herbert Xu
2005-05-21 20:18 ` YOSHIFUJI Hideaki / 吉藤英明
2005-05-22 7:34 ` Herbert Xu [this message]
2005-05-23 20:11 ` David S. Miller
2005-05-21 21:49 ` Christophe Saout
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050522073435.GA15867@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=christophe@saout.de \
--cc=davem@davemloft.net \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox