From: Francois Romieu <romieu@fr.zoreil.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
jketreno@linux.intel.com, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ipw2200: Fix NETDEV_TX_BUSY erroneous returned
Date: Thu, 5 Jan 2006 00:52:47 +0100 [thread overview]
Message-ID: <20060104235247.GA8137@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20060104040954.GA19618@mail.intel.com>
Zhu Yi <yi.zhu@intel.com> :
>
> This patch fixes the warning below warning for the ipw2200 driver.
>
> NETDEV_TX_BUSY returned; driver should report queue full via
> ieee_device->is_queue_full.
Beyond what was said by Stephen Hemminger, the driver reports a
NETDEV_TX_BUSY when !STATUS_ASSOCIATED: neither this patch nor mine
fix it.
Btw the patch that I posted earlier forgets to protect against
every undue wake-up through:
ipw_rx
-> ipw_rx_notification
-> priv->link_up (work_queue)
-> ipw_bg_link_up
-> ipw_link_up
It will need some extra care to correctly play the
netif_{stop/wake}_queue dance.
--
Ueimor
parent reply other threads:[~2006-01-04 23:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20060104040954.GA19618@mail.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060104235247.GA8137@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=jketreno@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox