* Re: [PATCH] ipw2200: Fix NETDEV_TX_BUSY erroneous returned
[not found] <20060104040954.GA19618@mail.intel.com>
@ 2006-01-04 23:52 ` Francois Romieu
0 siblings, 0 replies; only message in thread
From: Francois Romieu @ 2006-01-04 23:52 UTC (permalink / raw)
To: Zhu Yi; +Cc: Andrew Morton, jketreno, jgarzik, linux-kernel, netdev
Zhu Yi <yi.zhu@intel.com> :
>
> This patch fixes the warning below warning for the ipw2200 driver.
>
> NETDEV_TX_BUSY returned; driver should report queue full via
> ieee_device->is_queue_full.
Beyond what was said by Stephen Hemminger, the driver reports a
NETDEV_TX_BUSY when !STATUS_ASSOCIATED: neither this patch nor mine
fix it.
Btw the patch that I posted earlier forgets to protect against
every undue wake-up through:
ipw_rx
-> ipw_rx_notification
-> priv->link_up (work_queue)
-> ipw_bg_link_up
-> ipw_link_up
It will need some extra care to correctly play the
netif_{stop/wake}_queue dance.
--
Ueimor
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-01-04 23:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060104040954.GA19618@mail.intel.com>
2006-01-04 23:52 ` [PATCH] ipw2200: Fix NETDEV_TX_BUSY erroneous returned Francois Romieu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox