[PATCH] ipx: correct return type of ipxrtr

Netdev List
 help / color / mirror / Atom feed

* [PATCH] ipx: correct return type of ipxrtr_delete
@ 2006-05-16 20:12 Alexey Dobriyan
  2006-05-16 22:08 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-05-16 20:12 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Arnaldo Carvalho de Melo, netdev

A single caller passes __u32. Inside function "net" is compared with
__u32 (__be32 really, just wasn't annotated).

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

--- a/net/ipx/ipx_route.c
+++ b/net/ipx/ipx_route.c
@@ -119,7 +119,7 @@ out:
 	return rc;
 }
 
-static int ipxrtr_delete(long net)
+static int ipxrtr_delete(__u32 net)
 {
 	struct ipx_route *r, *tmp;
 	int rc;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipx: correct return type of ipxrtr_delete
  2006-05-16 20:12 [PATCH] ipx: correct return type of ipxrtr_delete Alexey Dobriyan
@ 2006-05-16 22:08 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2006-05-16 22:08 UTC (permalink / raw)
  To: adobriyan; +Cc: akpm, acme, netdev

From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Wed, 17 May 2006 00:12:38 +0400

> A single caller passes __u32. Inside function "net" is compared with
> __u32 (__be32 really, just wasn't annotated).
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

Applied, but I had to fix your changelog, you're fixing the
"argument" type not the "return" type. :)

Thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-05-16 22:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-16 20:12 [PATCH] ipx: correct return type of ipxrtr_delete Alexey Dobriyan
2006-05-16 22:08 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox