[RFC] new qla3xxx NIC Driver v2.02.00k19

[RFC] new qla3xxx NIC Driver v2.02.00k19

[Ron Mercer]

All,

Second submission for the upstream inclusion of the qla3xxx Ethernet
driver. This is a complementary network driver for our ISP4XXX parts.
There is a concurrent effort underway to get the iSCSI driver (qla4xxx)
integrated upstream as well.

The following files are included and have been posted to the link below:

LICENSE.qla3xxx
qla3xxxsrc-v2.02.00k19.tgz

ftp://ftp.qlogic.com/outgoing/linux/network/upstream/2.02.00k19/

Original submission:
http://marc.theaimsgroup.com/?l=linux-netdev&m=114254712431781&w=2

Comments from original submission:
http://marc.theaimsgroup.com/?l=linux-netdev&m=114263130100996&w=2

Changes in this release:
-Removed double buffering on receives.
-Added NAPI support.
-Removed elements in device structure that were already in netdev.
-Changed to pci_xxx_consistent calls instead of dma_xxx_coherent.
-Added ethtool support.
-Changed debug printing to use netif_msg_xxx.
-Changed DPC thread to work queue.
-Inlined numerous functions.
-Changed all functions to statics.
-Combined all source files to a single file.


Work in progress:
-Removal of debug functions.
-Possible changes for big endian architecture.

The driver has been built and tested using kernel 2.6.16-rc5.


Looking forward to any and all feedback.

Regards,

Ron Mercer
Qlogic Corporation

Re: [RFC] new qla3xxx NIC Driver v2.02.00k19

[Francois Romieu]

Ron Mercer <ron.mercer@qlogic.com> :
[...]
> Looking forward to any and all feedback.

First pass:
- please reorder the code so that the forward declarations are not needed
- the typedefs (say PQL3XXX_PORT_REGISTERS) hide pointer information.
  They are useless (and capitalized :o/ ). Just say no to typedef.
- the debug functions abuse copy/paste. Please use struct array + loop
  if you really want these to stay.
- "return" is not a function. It does not need parenthesis.
- 80 colums disease in ql_link_state_machine. The indentation is terrible.
- label for goto should be at the start of the line.
- acquire_adapter_lock must go. Conditional locking is a pain to maintain.
- the error path in ql3xxx_probe is broken. Use named _and_ numbered
  goto if you want to avoid it (i.e. "goto err_undo_something_1" then
  "goto err_undo_something_else_2", etc.).
- ql_set_ethtool_ops() is useless bloat. Please remove.
- QL_LOCK_DRVR_WAIT should be a function, not a macro
- the status code should be propagated (request_irq, pci_enable_device,
  pci_request_regions, etc.).
- no __iomem, __u32, __le32 ? Seems strange.
- replace return (0) with NETDEV_TX_OK in ql3xxx_send
  (and s/send/start_xmit/ ?).

-- 
Ueimor