[PATCH] unsigned long => __be32 in icmp

Netdev List
 help / color / mirror / Atom feed

* [PATCH] unsigned long => __be32 in icmp_redirect()
@ 2006-05-27 21:29 Alexey Dobriyan
  2006-06-06  4:18 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-05-27 21:29 UTC (permalink / raw)
  To: netdev

ip_rt_redirect() expects __be32 as second arg, so...

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

--- a/net/ipv4/icmp.c
+++ 1/net/ipv4/icmp.c
@@ -730,7 +730,7 @@ out_err:
 static void icmp_redirect(struct sk_buff *skb)
 {
 	struct iphdr *iph;
-	unsigned long ip;
+	__be32 ip;
 
 	if (skb->len < sizeof(struct iphdr))
 		goto out_err;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] unsigned long => __be32 in icmp_redirect()
  2006-05-27 21:29 [PATCH] unsigned long => __be32 in icmp_redirect() Alexey Dobriyan
@ 2006-06-06  4:18 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-06-06  4:18 UTC (permalink / raw)
  To: adobriyan; +Cc: netdev

From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Sun, 28 May 2006 01:29:25 +0400

> ip_rt_redirect() expects __be32 as second arg, so...
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

I'm going to cure this by simple killing the 'ip' variable
altogether.  It is assigned once, to iph->daddr, and used
once, as an argument.  So just pass iph->daddr directly.

Thanks for finding this.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-06-06  4:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-27 21:29 [PATCH] unsigned long => __be32 in icmp_redirect() Alexey Dobriyan
2006-06-06  4:18 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox