Re: [Bug 6688] Memory allocation problem

Re: [Bug 6688] Memory allocation problem

[Andrew Morton]

On Mon, 19 Jun 2006 23:46:08 -0700
bugme-daemon@bugzilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=6688

This is looking like a net memory leak in 2.6.16.  1/3rd is in ip_fib_alias
and 2/3rds is in size-64.  I've asked the reporter to apply the leak
detector patch so we can find out who is using the size-64 part.

Re: [Bug 6688] Memory allocation problem

[Herbert Xu]

Andrew Morton <akpm@osdl.org> wrote:
> On Mon, 19 Jun 2006 23:46:08 -0700
> bugme-daemon@bugzilla.kernel.org wrote:
> 
>> http://bugzilla.kernel.org/show_bug.cgi?id=6688
> 
> This is looking like a net memory leak in 2.6.16.  1/3rd is in ip_fib_alias
> and 2/3rds is in size-64.  I've asked the reporter to apply the leak
> detector patch so we can find out who is using the size-64 part.

I had a look at fib_trie.c and found a bug.  This is probably not the
cause of the leak since it looks more likely to cause a crash than
anything.  However, please retest with this applied just to be sure.

[IPV4]: Fix error handling for fib_insert_node call

The error handling around fib_insert_node was broken because we always
zeroed the error before checking it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [Bug 6688] Memory allocation problem

[Herbert Xu]

On Wed, Jul 12, 2006 at 09:44:46PM +1000, Herbert Xu wrote:
> 
> [IPV4]: Fix error handling for fib_insert_node call

Doh, fogot the patch.

[IPV4]: Fix error handling for fib_insert_node call

The error handling around fib_insert_node was broken because we always
zeroed the error before checking it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 1cb6530..23fb9d9 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -1252,8 +1252,8 @@ fn_trie_insert(struct fib_table *tb, str
 	 */
 
 	if (!fa_head) {
-		fa_head = fib_insert_node(t, &err, key, plen);
 		err = 0;
+		fa_head = fib_insert_node(t, &err, key, plen);
 		if (err)
 			goto out_free_new_fa;
 	}

Re: [Bug 6688] Memory allocation problem

[David Miller]

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 12 Jul 2006 21:45:13 +1000

> [IPV4]: Fix error handling for fib_insert_node call
> 
> The error handling around fib_insert_node was broken because we always
> zeroed the error before checking it.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, thanks Herbert.