From: Herbert Xu <herbert@gondor.apana.org.au>
To: akpm@osdl.org
Cc: mm-commits@vger.kernel.org, bgoglin@myri.com,
davem@davemloft.net, jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: + myri10ge-build-fix.patch added to -mm tree
Date: Wed, 21 Jun 2006 14:41:07 +1000 [thread overview]
Message-ID: <20060621044107.GB899@gondor.apana.org.au> (raw)
In-Reply-To: <200606210433.k5L4XgmP008626@shell0.pdx.osdl.net>
On Tue, Jun 20, 2006 at 09:33:42PM -0700, akpm@osdl.org wrote:
>
> diff -puN drivers/net/myri10ge/myri10ge.c~myri10ge-build-fix drivers/net/myri10ge/myri10ge.c
> --- a/drivers/net/myri10ge/myri10ge.c~myri10ge-build-fix
> +++ a/drivers/net/myri10ge/myri10ge.c
> @@ -2120,7 +2120,7 @@ abort_linearize:
> goto drop;
> }
>
> - if (skb_linearize(skb, GFP_ATOMIC))
> + if (skb_linearize(skb))
> goto drop;
Actually I think this driver (in conjunction with TSO) is buggy.
It has a maximum segment count of 12. However TSO can send 13 pages
or more of data on i386. If this happens it looks like this driver
will go into an infinite loop forever trying to linearize the skb.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next parent reply other threads:[~2006-06-21 4:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606210433.k5L4XgmP008626@shell0.pdx.osdl.net>
2006-06-21 4:41 ` Herbert Xu [this message]
2006-06-21 12:09 ` + myri10ge-build-fix.patch added to -mm tree Brice Goglin
2006-06-21 12:28 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060621044107.GB899@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@osdl.org \
--cc=bgoglin@myri.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=mm-commits@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox