From: Brice Goglin <brice@myri.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: akpm@osdl.org, mm-commits@vger.kernel.org, davem@davemloft.net,
jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: + myri10ge-build-fix.patch added to -mm tree
Date: Wed, 21 Jun 2006 08:09:51 -0400 [thread overview]
Message-ID: <4499370F.2020101@myri.com> (raw)
In-Reply-To: <20060621044107.GB899@gondor.apana.org.au>
Herbert Xu wrote:
> On Tue, Jun 20, 2006 at 09:33:42PM -0700, akpm@osdl.org wrote:
>> diff -puN drivers/net/myri10ge/myri10ge.c~myri10ge-build-fix
>> drivers/net/myri10ge/myri10ge.c
>> --- a/drivers/net/myri10ge/myri10ge.c~myri10ge-build-fix
>> +++ a/drivers/net/myri10ge/myri10ge.c
>> @@ -2120,7 +2120,7 @@ abort_linearize:
>> goto drop;
>> }
>>
>> - if (skb_linearize(skb, GFP_ATOMIC))
>> + if (skb_linearize(skb))
>> goto drop;
>
> Actually I think this driver (in conjunction with TSO) is buggy.
> It has a maximum segment count of 12. However TSO can send 13 pages
> or more of data on i386. If this happens it looks like this driver
> will go into an infinite loop forever trying to linearize the skb.
>
> Cheers,
Actually, we use 64 segments when TSO in enabled
(MYRI10GE_MAX_SEND_DESC_TSO):
#define MYRI10GE_MAX_SEND_DESC_TSO ((65536 / 2048) * 2)
<.....>
max_segments = MXGEFW_MAX_SEND_DESC;
#ifdef NETIF_F_TSO
if (skb->len > (dev->mtu + ETH_HLEN)) {
mss = skb_shinfo(skb)->tso_size;
if (mss != 0)
max_segments = MYRI10GE_MAX_SEND_DESC_TSO;
}
#endif /*NETIF_F_TSO */
And we never try to linearize a TSO frame:
if (skb_shinfo(skb)->tso_size) {
printk(KERN_ERR "myri10ge: %s: TSO but wanted to linearize?!?!?\n",
mgp->dev->name);
goto drop;
}
Brice
next prev parent reply other threads:[~2006-06-21 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606210433.k5L4XgmP008626@shell0.pdx.osdl.net>
2006-06-21 4:41 ` + myri10ge-build-fix.patch added to -mm tree Herbert Xu
2006-06-21 12:09 ` Brice Goglin [this message]
2006-06-21 12:28 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4499370F.2020101@myri.com \
--to=brice@myri.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=mm-commits@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox