[patch 2/6] netpoll: don't spin forever sending to stopped queues

[patch 2/6] netpoll: don't spin forever sending to stopped queues

[akpm]

From: Jeremy Fitzhardinge <jeremy@goop.org>

When transmitting a skb in netpoll_send_skb(), only retry a limited number
of times if the device queue is stopped.

Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 net/core/netpoll.c |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff -puN net/core/netpoll.c~netpoll-dont-spin-forever-sending-to-blocked-queues net/core/netpoll.c
--- a/net/core/netpoll.c~netpoll-dont-spin-forever-sending-to-blocked-queues
+++ a/net/core/netpoll.c
@@ -279,14 +279,10 @@ static void netpoll_send_skb(struct netp
 		 * network drivers do not expect to be called if the queue is
 		 * stopped.
 		 */
-		if (netif_queue_stopped(np->dev)) {
-			netif_tx_unlock(np->dev);
-			netpoll_poll(np);
-			udelay(50);
-			continue;
-		}
+		status = NETDEV_TX_BUSY;
+		if (!netif_queue_stopped(np->dev))
+			status = np->dev->hard_start_xmit(skb, np->dev);
 
-		status = np->dev->hard_start_xmit(skb, np->dev);
 		netif_tx_unlock(np->dev);
 
 		/* success */
_

Re: [patch 2/6] netpoll: don't spin forever sending to stopped queues

[David Miller]

From: akpm@osdl.org
Date: Sun, 25 Jun 2006 01:47:29 -0700

> 
> From: Jeremy Fitzhardinge <jeremy@goop.org>
> 
> When transmitting a skb in netpoll_send_skb(), only retry a limited number
> of times if the device queue is stopped.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
> Acked-by: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>

Applied, thanks.