From: David Miller <davem@davemloft.net>
To: rdunlap@xenotime.net
Cc: christopher.leech@intel.com, andrew.grover@intel.com,
netdev@vger.kernel.org
Subject: Re: IOAT stuff
Date: Mon, 26 Jun 2006 15:49:32 -0700 (PDT) [thread overview]
Message-ID: <20060626.154932.55726803.davem@davemloft.net> (raw)
In-Reply-To: <20060626152939.962b56e6.rdunlap@xenotime.net>
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Mon, 26 Jun 2006 15:29:39 -0700
> drivers/dma/ioatdma.c:830: warning: no return statement in function returning non-void
> drivers/dma/ioatdma.c:830: warning: control reaches end of non-void function
>
> Maybe insert "return" in front of:
>
> pci_module_init(&ioat_pci_drv);
>
> or is there some reason not to do that?
>
> BTW, pci_module_init() is obsolete. Drivers should be using
> pci_register_driver() instead.
>
> PS: IOAT/DMA (whatever) needs a MAINTAINERS entry.
It also still has the cpu hotplug locking bug, which none of the
I/O AT developers have even mentioned that they'd try to fix.
To reiterate, it tries to lock hotplug while holding spinlocks
which is illegal because locking hotplug takes a semaphore which
can sleep.
prev parent reply other threads:[~2006-06-26 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 22:29 IOAT stuff Randy.Dunlap
2006-06-26 22:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060626.154932.55726803.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.grover@intel.com \
--cc=christopher.leech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox