* IOAT stuff
@ 2006-06-26 22:29 Randy.Dunlap
2006-06-26 22:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Randy.Dunlap @ 2006-06-26 22:29 UTC (permalink / raw)
To: christopher.leech, andrew.grover; +Cc: netdev
drivers/dma/ioatdma.c:830: warning: no return statement in function returning non-void
drivers/dma/ioatdma.c:830: warning: control reaches end of non-void function
Maybe insert "return" in front of:
pci_module_init(&ioat_pci_drv);
or is there some reason not to do that?
BTW, pci_module_init() is obsolete. Drivers should be using
pci_register_driver() instead.
PS: IOAT/DMA (whatever) needs a MAINTAINERS entry.
---
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: IOAT stuff
2006-06-26 22:29 IOAT stuff Randy.Dunlap
@ 2006-06-26 22:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-06-26 22:49 UTC (permalink / raw)
To: rdunlap; +Cc: christopher.leech, andrew.grover, netdev
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Mon, 26 Jun 2006 15:29:39 -0700
> drivers/dma/ioatdma.c:830: warning: no return statement in function returning non-void
> drivers/dma/ioatdma.c:830: warning: control reaches end of non-void function
>
> Maybe insert "return" in front of:
>
> pci_module_init(&ioat_pci_drv);
>
> or is there some reason not to do that?
>
> BTW, pci_module_init() is obsolete. Drivers should be using
> pci_register_driver() instead.
>
> PS: IOAT/DMA (whatever) needs a MAINTAINERS entry.
It also still has the cpu hotplug locking bug, which none of the
I/O AT developers have even mentioned that they'd try to fix.
To reiterate, it tries to lock hotplug while holding spinlocks
which is illegal because locking hotplug takes a semaphore which
can sleep.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-26 22:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-26 22:29 IOAT stuff Randy.Dunlap
2006-06-26 22:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox