Netdev List
 help / color / mirror / Atom feed
* [patch] bridge: br_dump_ifinfo index fix
@ 2006-07-03 12:06 Andrey Savochkin
  2006-07-04  2:50 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Savochkin @ 2006-07-03 12:06 UTC (permalink / raw)
  To: netdev; +Cc: Kirill Korotaev, Ben Greear, Stephen Hemminger

Fix for inability of br_dump_ifinfo to handle non-zero start index:
loop index never increases when entered with non-zero start.
Spotted by Kirill Korotaev.

Signed-off-by: Andrey Savochkin <saw@swsoft.com>
Cc: Kirill Korotaev <dev@openvz.org>
---
Against 2.6.17-mm6

--- ./net/bridge/br_netlink.c.vebridge-dump	Wed Jun 21 18:53:18 2006
+++ ./net/bridge/br_netlink.c	Mon Jul  3 14:31:03 2006
@@ -117,12 +117,13 @@ static int br_dump_ifinfo(struct sk_buff
 			continue;
 
 		if (idx < s_idx)
-			continue;
+			goto cont;
 
 		err = br_fill_ifinfo(skb, p, NETLINK_CB(cb->skb).pid,
 				     cb->nlh->nlmsg_seq, RTM_NEWLINK, NLM_F_MULTI);
 		if (err <= 0)
 			break;
+cont:
 		++idx;
 	}
 	read_unlock(&dev_base_lock);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-07-04  2:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-03 12:06 [patch] bridge: br_dump_ifinfo index fix Andrey Savochkin
2006-07-04  2:50 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox