From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: gerrit@erg.abdn.ac.uk, jmorris@namei.org
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCHv2 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code
Date: Fri, 18 Aug 2006 00:18:20 +0900 (JST) [thread overview]
Message-ID: <20060818.001820.05196705.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0608171054560.19149@d.namei>
Hi,
In article <Pine.LNX.4.64.0608171054560.19149@d.namei> (at Thu, 17 Aug 2006 10:56:40 -0400 (EDT)), James Morris <jmorris@namei.org> says:
> On Thu, 17 Aug 2006, gerrit@erg.abdn.ac.uk wrote:
>
> > - if (inet2->num == snum &&
> > - sk2 != sk &&
> > - !ipv6_only_sock(sk2) &&
> > - (!sk2->sk_bound_dev_if ||
> > - !sk->sk_bound_dev_if ||
> > - sk2->sk_bound_dev_if == sk->sk_bound_dev_if) &&
>
>
> > + sk_for_each(sk2, node, head)
> > + if (inet_sk(sk2)->num == snum &&
> > + sk2 != sk &&
> > + (!sk2->sk_reuse || !sk->sk_reuse) &&
> > + (!sk2->sk_bound_dev_if || !sk->sk_bound_dev_if
> > + || sk2->sk_bound_dev_if == sk->sk_bound_dev_if) &&
>
>
> Doesn't this change the behavior for IPV6_V6ONLY sockets ?
It is tested in ipv4_rcv_saddr_equal() (called vi saddr_cmp), isn't it?
--yoshfuji
next prev parent reply other threads:[~2006-08-17 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 12:25 [PATCHv2 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code gerrit
2006-08-17 14:56 ` James Morris
2006-08-17 15:18 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2006-08-27 3:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060818.001820.05196705.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox