Re: [PATCHv2 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code

[David Miller <davem@davemloft.net>]

From: gerrit@erg.abdn.ac.uk
Date: Thu, 17 Aug 2006 13:25:46 +0100

> [NET]: UDPv4 and UDPv6 use an almost identical version of the get_port function,
> which is unnecessary since the (long) code differs in only one if-statement.
> 
> This patch creates one common function which is called by udp_v4_get_port() and
> udp_v6_get_port(). As a result,
>   * duplicated code is removed
>   * udp_port_rover and local port lookup can now be removed from udp.h
>   * further savings follow since the same function will be used by UDP-Litev4 
>     and UDP-Litev6
> 
> In contrast to the patch sent in response to Yoshifujis comments (fixed by this
> variant), the code below also removes the EXPORT_SYMBOL(udp_port_rover), since
> udp_port_rover can now remain local to net/ipv4/udp.c.
> 
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>

Applied, and I marked udp_port_rover "static" for
good measure.

Thanks.