* [PATCH] tcp_bic: use BUILD_BUG_ON
@ 2006-08-25 1:08 Alexey Dobriyan
2006-08-25 7:37 ` David Miller
2006-08-25 23:27 ` Stephen Hemminger
0 siblings, 2 replies; 5+ messages in thread
From: Alexey Dobriyan @ 2006-08-25 1:08 UTC (permalink / raw)
To: netdev
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
net/ipv4/tcp_bic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/ipv4/tcp_bic.c
+++ b/net/ipv4/tcp_bic.c
@@ -231,7 +231,7 @@ static struct tcp_congestion_ops bictcp
static int __init bictcp_register(void)
{
- BUG_ON(sizeof(struct bictcp) > ICSK_CA_PRIV_SIZE);
+ BUILD_BUG_ON(sizeof(struct bictcp) > ICSK_CA_PRIV_SIZE);
return tcp_register_congestion_control(&bictcp);
}
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] tcp_bic: use BUILD_BUG_ON 2006-08-25 1:08 [PATCH] tcp_bic: use BUILD_BUG_ON Alexey Dobriyan @ 2006-08-25 7:37 ` David Miller 2006-08-25 23:27 ` Stephen Hemminger 1 sibling, 0 replies; 5+ messages in thread From: David Miller @ 2006-08-25 7:37 UTC (permalink / raw) To: adobriyan; +Cc: netdev From: Alexey Dobriyan <adobriyan@gmail.com> Date: Fri, 25 Aug 2006 05:08:02 +0400 > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Applied. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tcp_bic: use BUILD_BUG_ON 2006-08-25 1:08 [PATCH] tcp_bic: use BUILD_BUG_ON Alexey Dobriyan 2006-08-25 7:37 ` David Miller @ 2006-08-25 23:27 ` Stephen Hemminger 2006-08-25 23:57 ` [PATCH] Congestion control (modulo lp, bic): " Alexey Dobriyan 1 sibling, 1 reply; 5+ messages in thread From: Stephen Hemminger @ 2006-08-25 23:27 UTC (permalink / raw) To: Alexey Dobriyan; +Cc: netdev Please fix the other variants as well htcp, cubic, veno, vegas, ... Just one patch is necessary with all the files. -- Stephen Hemminger <shemminger@osdl.org> All non-trivial abstractions, to some degree, are leaky. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Congestion control (modulo lp, bic): use BUILD_BUG_ON 2006-08-25 23:27 ` Stephen Hemminger @ 2006-08-25 23:57 ` Alexey Dobriyan 2006-08-26 0:10 ` David Miller 0 siblings, 1 reply; 5+ messages in thread From: Alexey Dobriyan @ 2006-08-25 23:57 UTC (permalink / raw) To: Stephen Hemminger; +Cc: netdev Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- net/ipv4/tcp_cubic.c | 2 +- net/ipv4/tcp_highspeed.c | 2 +- net/ipv4/tcp_htcp.c | 2 +- net/ipv4/tcp_hybla.c | 2 +- net/ipv4/tcp_vegas.c | 2 +- net/ipv4/tcp_veno.c | 2 +- net/ipv4/tcp_westwood.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) --- a/net/ipv4/tcp_cubic.c +++ b/net/ipv4/tcp_cubic.c @@ -358,7 +358,7 @@ static struct tcp_congestion_ops cubictc static int __init cubictcp_register(void) { - BUG_ON(sizeof(struct bictcp) > ICSK_CA_PRIV_SIZE); + BUILD_BUG_ON(sizeof(struct bictcp) > ICSK_CA_PRIV_SIZE); /* Precompute a bunch of the scaling factors that are used per-packet * based on SRTT of 100ms --- a/net/ipv4/tcp_highspeed.c +++ b/net/ipv4/tcp_highspeed.c @@ -189,7 +189,7 @@ static struct tcp_congestion_ops tcp_hig static int __init hstcp_register(void) { - BUG_ON(sizeof(struct hstcp) > ICSK_CA_PRIV_SIZE); + BUILD_BUG_ON(sizeof(struct hstcp) > ICSK_CA_PRIV_SIZE); return tcp_register_congestion_control(&tcp_highspeed); } --- a/net/ipv4/tcp_htcp.c +++ b/net/ipv4/tcp_htcp.c @@ -286,7 +286,7 @@ static struct tcp_congestion_ops htcp = static int __init htcp_register(void) { - BUG_ON(sizeof(struct htcp) > ICSK_CA_PRIV_SIZE); + BUILD_BUG_ON(sizeof(struct htcp) > ICSK_CA_PRIV_SIZE); BUILD_BUG_ON(BETA_MIN >= BETA_MAX); return tcp_register_congestion_control(&htcp); } --- a/net/ipv4/tcp_hybla.c +++ b/net/ipv4/tcp_hybla.c @@ -170,7 +170,7 @@ static struct tcp_congestion_ops tcp_hyb static int __init hybla_register(void) { - BUG_ON(sizeof(struct hybla) > ICSK_CA_PRIV_SIZE); + BUILD_BUG_ON(sizeof(struct hybla) > ICSK_CA_PRIV_SIZE); return tcp_register_congestion_control(&tcp_hybla); } --- a/net/ipv4/tcp_vegas.c +++ b/net/ipv4/tcp_vegas.c @@ -370,7 +370,7 @@ static struct tcp_congestion_ops tcp_veg static int __init tcp_vegas_register(void) { - BUG_ON(sizeof(struct vegas) > ICSK_CA_PRIV_SIZE); + BUILD_BUG_ON(sizeof(struct vegas) > ICSK_CA_PRIV_SIZE); tcp_register_congestion_control(&tcp_vegas); return 0; } --- a/net/ipv4/tcp_veno.c +++ b/net/ipv4/tcp_veno.c @@ -213,7 +213,7 @@ static struct tcp_congestion_ops tcp_ven static int __init tcp_veno_register(void) { - BUG_ON(sizeof(struct veno) > ICSK_CA_PRIV_SIZE); + BUILD_BUG_ON(sizeof(struct veno) > ICSK_CA_PRIV_SIZE); tcp_register_congestion_control(&tcp_veno); return 0; } --- a/net/ipv4/tcp_westwood.c +++ b/net/ipv4/tcp_westwood.c @@ -289,7 +289,7 @@ static struct tcp_congestion_ops tcp_wes static int __init tcp_westwood_register(void) { - BUG_ON(sizeof(struct westwood) > ICSK_CA_PRIV_SIZE); + BUILD_BUG_ON(sizeof(struct westwood) > ICSK_CA_PRIV_SIZE); return tcp_register_congestion_control(&tcp_westwood); } ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Congestion control (modulo lp, bic): use BUILD_BUG_ON 2006-08-25 23:57 ` [PATCH] Congestion control (modulo lp, bic): " Alexey Dobriyan @ 2006-08-26 0:10 ` David Miller 0 siblings, 0 replies; 5+ messages in thread From: David Miller @ 2006-08-26 0:10 UTC (permalink / raw) To: adobriyan; +Cc: shemminger, netdev From: Alexey Dobriyan <adobriyan@gmail.com> Date: Sat, 26 Aug 2006 03:57:41 +0400 > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Applied, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-08-26 0:10 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-08-25 1:08 [PATCH] tcp_bic: use BUILD_BUG_ON Alexey Dobriyan 2006-08-25 7:37 ` David Miller 2006-08-25 23:27 ` Stephen Hemminger 2006-08-25 23:57 ` [PATCH] Congestion control (modulo lp, bic): " Alexey Dobriyan 2006-08-26 0:10 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox