* [PATCH] tcp-lp: prevent chance for oops
@ 2006-09-28 10:43 Wong Edison
2006-09-28 21:38 ` David Miller
2006-09-28 21:40 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Wong Edison @ 2006-09-28 10:43 UTC (permalink / raw)
To: netdev, David S. Miller, Stephen Hemminger
This patch fix the chance for tcp_lp_remote_hz_estimator return 0, if
0 < rhz < 64. It also make sure the flag LP_VALID_RHZ is set
correctly.
Signed-off-by: Wong Hoi Sing Edison <hswong3i@gmail.com>
---
diff -urpN linux-2.6.18/net/ipv4/tcp_lp.c linux/net/ipv4/tcp_lp.c
--- linux-2.6.18/net/ipv4/tcp_lp.c 2006-09-20 11:42:06.000000000 +0800
+++ linux/net/ipv4/tcp_lp.c 2006-09-28 18:30:17.000000000 +0800
@@ -32,7 +32,7 @@
* SourceForge project page:
* http://tcp-lp-mod.sourceforge.net/
*
- * Version: $Id: tcp_lp.c,v 1.24 2006/09/05 20:22:53 hswong3i Exp $
+ * Version: $Id: tcp_lp.c,v 1.25 2006/09/22 20:50:27 hswong3i Exp $
*/
#include <linux/config.h>
@@ -165,7 +165,7 @@ static u32 tcp_lp_remote_hz_estimator(st
out:
/* record time for successful remote HZ calc */
- if (rhz > 0)
+ if ((rhz >> 6) > 0)
lp->flag |= LP_VALID_RHZ;
else
lp->flag &= ~LP_VALID_RHZ;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcp-lp: prevent chance for oops
2006-09-28 10:43 [PATCH] tcp-lp: prevent chance for oops Wong Edison
@ 2006-09-28 21:38 ` David Miller
2006-09-28 21:40 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2006-09-28 21:38 UTC (permalink / raw)
To: hswong3i; +Cc: netdev, shemminger
From: "Wong Edison" <hswong3i@gmail.com>
Date: Thu, 28 Sep 2006 18:43:58 +0800
> This patch fix the chance for tcp_lp_remote_hz_estimator return 0, if
> 0 < rhz < 64. It also make sure the flag LP_VALID_RHZ is set
> correctly.
>
> Signed-off-by: Wong Hoi Sing Edison <hswong3i@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcp-lp: prevent chance for oops
2006-09-28 10:43 [PATCH] tcp-lp: prevent chance for oops Wong Edison
2006-09-28 21:38 ` David Miller
@ 2006-09-28 21:40 ` David Miller
2006-09-29 19:27 ` Wong Edison
1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2006-09-28 21:40 UTC (permalink / raw)
To: hswong3i; +Cc: netdev, shemminger
From: "Wong Edison" <hswong3i@gmail.com>
Date: Thu, 28 Sep 2006 18:43:58 +0800
> *
> - * Version: $Id: tcp_lp.c,v 1.24 2006/09/05 20:22:53 hswong3i Exp $
> + * Version: $Id: tcp_lp.c,v 1.25 2006/09/22 20:50:27 hswong3i Exp $
BTW, I'm deleting this line from the source file in the tree
because every patch you send doesn't apply cleanly because
your patch is against a different string on this line and we
don't use $Id$ tags in the kernel sources anyways.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcp-lp: prevent chance for oops
2006-09-28 21:40 ` David Miller
@ 2006-09-29 19:27 ` Wong Edison
2006-09-29 21:19 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Wong Edison @ 2006-09-29 19:27 UTC (permalink / raw)
To: David Miller; +Cc: netdev, shemminger
I do this since i have a sourceforge homepage for it. I update the CVS
version there, test, and then submit to netdev. As I sync code in both
side, this $Id$ is keeped.
May you just let it be? I think it will let my maintenance become more simple...
On 9/29/06, David Miller <davem@davemloft.net> wrote:
> From: "Wong Edison" <hswong3i@gmail.com>
> Date: Thu, 28 Sep 2006 18:43:58 +0800
>
> > *
> > - * Version: $Id: tcp_lp.c,v 1.24 2006/09/05 20:22:53 hswong3i Exp $
> > + * Version: $Id: tcp_lp.c,v 1.25 2006/09/22 20:50:27 hswong3i Exp $
>
> BTW, I'm deleting this line from the source file in the tree
> because every patch you send doesn't apply cleanly because
> your patch is against a different string on this line and we
> don't use $Id$ tags in the kernel sources anyways.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcp-lp: prevent chance for oops
2006-09-29 19:27 ` Wong Edison
@ 2006-09-29 21:19 ` David Miller
2006-09-30 10:54 ` Wong Edison
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2006-09-29 21:19 UTC (permalink / raw)
To: hswong3i; +Cc: netdev, shemminger
From: "Wong Edison" <hswong3i@gmail.com>
Date: Sat, 30 Sep 2006 03:27:00 +0800
> I do this since i have a sourceforge homepage for it. I update the
> CVS version there, test, and then submit to netdev. As I sync code
> in both side, this $Id$ is keeped. May you just let it be? I think
> it will let my maintenance become more simple...
You could not even generate a clean patch to me, it just
gets in the way and causes more work for me and anyone
else who tries to use your patches.
If you want to use versioning, use MODULE_VERSION() just like
everyone else in the kernel does.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tcp-lp: prevent chance for oops
2006-09-29 21:19 ` David Miller
@ 2006-09-30 10:54 ` Wong Edison
0 siblings, 0 replies; 6+ messages in thread
From: Wong Edison @ 2006-09-30 10:54 UTC (permalink / raw)
To: David Miller; +Cc: netdev, shemminger
oic i learn it and will change it in coming on version
On 9/30/06, David Miller <davem@davemloft.net> wrote:
> From: "Wong Edison" <hswong3i@gmail.com>
> Date: Sat, 30 Sep 2006 03:27:00 +0800
>
> > I do this since i have a sourceforge homepage for it. I update the
> > CVS version there, test, and then submit to netdev. As I sync code
> > in both side, this $Id$ is keeped. May you just let it be? I think
> > it will let my maintenance become more simple...
>
> You could not even generate a clean patch to me, it just
> gets in the way and causes more work for me and anyone
> else who tries to use your patches.
>
> If you want to use versioning, use MODULE_VERSION() just like
> everyone else in the kernel does.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-09-30 10:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-28 10:43 [PATCH] tcp-lp: prevent chance for oops Wong Edison
2006-09-28 21:38 ` David Miller
2006-09-28 21:40 ` David Miller
2006-09-29 19:27 ` Wong Edison
2006-09-29 21:19 ` David Miller
2006-09-30 10:54 ` Wong Edison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox