* Re: [PATCHv2 1/2]: [NET]: Supporting UDP-Lite (RFC 3828) in Linux
[not found] <200611140848.45863@strip-the-willow>
@ 2006-11-15 4:19 ` David Miller
2006-11-15 7:58 ` Gerrit Renker
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2006-11-15 4:19 UTC (permalink / raw)
To: gerrit; +Cc: netdev
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 14 Nov 2006 08:48:45 +0000
> [NET]: Supporting UDP-Lite (RFC 3828) in Linux
>
> This is a revision of the previously submitted patch, which alters
> the way files are organized and compiled in the following manner:
>
> * UDP and UDP-Lite now use separate object files
> * source file dependencies resolved via header files
> net/ipv{4,6}/udp_impl.h
> * order of inclusion files in udp.c/udplite.c adapted
> accordingly
Looks excellent, applied to net-2.6.20, thanks Gerrit.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCHv2 1/2]: [NET]: Supporting UDP-Lite (RFC 3828) in Linux
2006-11-15 4:19 ` [PATCHv2 1/2]: [NET]: Supporting UDP-Lite (RFC 3828) in Linux David Miller
@ 2006-11-15 7:58 ` Gerrit Renker
2006-11-15 8:45 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Gerrit Renker @ 2006-11-15 7:58 UTC (permalink / raw)
To: David Miller; +Cc: netdev
| > [NET]: Supporting UDP-Lite (RFC 3828) in Linux
| applied to net-2.6.20, thanks Gerrit.
Many thanks indeed. During these changes I accidentally
forgot to restore udp_push_pending_frames to its static state.
Can you please consider the attached patch --
[NET/IPv4]: Make udp_push_pending_frames static
udp_push_pending_frames is only referenced within
net/ipv4/udp.c and hence can remain static.
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 227655c..ac613ed 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -447,7 +447,7 @@ static void udp4_hwcsum_outgoing(struct
/*
* Push out all pending data as one UDP datagram. Socket is locked.
*/
-int udp_push_pending_frames(struct sock *sk, struct udp_sock *up)
+static int udp_push_pending_frames(struct sock *sk, struct udp_sock *up)
{
struct inet_sock *inet = inet_sk(sk);
struct flowi *fl = &inet->cork.fl;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCHv2 1/2]: [NET]: Supporting UDP-Lite (RFC 3828) in Linux
2006-11-15 7:58 ` Gerrit Renker
@ 2006-11-15 8:45 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2006-11-15 8:45 UTC (permalink / raw)
To: gerrit; +Cc: netdev
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Wed, 15 Nov 2006 07:58:17 +0000
> [NET/IPv4]: Make udp_push_pending_frames static
> udp_push_pending_frames is only referenced within
> net/ipv4/udp.c and hence can remain static.
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied, thanks Gerrit.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-15 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200611140848.45863@strip-the-willow>
2006-11-15 4:19 ` [PATCHv2 1/2]: [NET]: Supporting UDP-Lite (RFC 3828) in Linux David Miller
2006-11-15 7:58 ` Gerrit Renker
2006-11-15 8:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox