From: David Miller <davem@davemloft.net>
To: t.hisch@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c
Date: Sun, 04 Feb 2007 12:23:48 -0800 (PST) [thread overview]
Message-ID: <20070204.122348.38681159.davem@davemloft.net> (raw)
In-Reply-To: <20070204142921.GA5787@unknown-00-0d-60-79-ca-00.lan>
From: Thomas Hisch <t.hisch@gmail.com>
Date: Sun, 4 Feb 2007 15:29:21 +0100
> remove unneeded call to skb_queue_len (skb_dequeue already checks queuelen) and
> replace a sizeof() by a Netlink Macro
>
> Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
You don't understand the code you are editing :-)
We want to process the number of packets present when we
start the function, other threads can add more packets to
the queue meanwhile and we don't want to keep dequeueing
in that case or else we can theoretically run forever with
a fast enough producer.
Also, please post all networking patches to netdev@vger.kernel.org,
the majority of the networking developers do not read linux-kernel.
Thank you.
next parent reply other threads:[~2007-02-04 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0612311547200.30821@localhost.localdomain>
[not found] ` <20070204142921.GA5787@unknown-00-0d-60-79-ca-00.lan>
2007-02-04 20:23 ` David Miller [this message]
2007-02-04 20:41 ` [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c Thomas Hisch
2007-02-04 15:34 Thomas Hisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070204.122348.38681159.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=t.hisch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox