Re: [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c

["Thomas Hisch" <t.hisch@gmail.com>]

On 2/4/07, David Miller <davem@davemloft.net> wrote:
> From: Thomas Hisch <t.hisch@gmail.com>
> Date: Sun, 4 Feb 2007 15:29:21 +0100
>
> > remove unneeded call to skb_queue_len (skb_dequeue already checks queuelen) and
> > replace a sizeof() by a Netlink Macro
> >
> > Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
>
> You don't understand the code you are editing :-)
>
> We want to process the number of packets present when we
> start the function, other threads can add more packets to
> the queue meanwhile and we don't want to keep dequeueing
> in that case or else we can theoretically run forever with
> a fast enough producer.
>
> Also, please post all networking patches to netdev@vger.kernel.org,
> the majority of the networking developers do not read linux-kernel.
>
> Thank you.
>
thanks for the advice. next time i should look more closely at the code ;)

i thought that this was a candidate for a cleanup as no other netlink
protocol used such a while loop condition.

Thomas.