Netdev List
 help / color / mirror / Atom feed
* [PATCH] Olympic (IBM PCI tokenring): handle return codes of register_netdev
@ 2007-04-20  6:52 Borislav Petkov
  0 siblings, 0 replies; only message in thread
From: Borislav Petkov @ 2007-04-20  6:52 UTC (permalink / raw)
  To: linux-tr, netdev; +Cc: kernel-janitors

Handle return codes of register_netdev().

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>


Index: 21-rc7/drivers/net/tokenring/olympic.c
===================================================================
--- 21-rc7.orig/drivers/net/tokenring/olympic.c
+++ 21-rc7/drivers/net/tokenring/olympic.c
@@ -264,7 +264,10 @@ static int __devinit olympic_probe(struc
 	SET_NETDEV_DEV(dev, &pdev->dev);
 
 	pci_set_drvdata(pdev,dev) ; 
-	register_netdev(dev) ; 
+
+	if (register_netdev(dev))
+		goto op_free_iomap;
+
 	printk("Olympic: %s registered as: %s\n",olympic_priv->olympic_card_name,dev->name);
 	if (olympic_priv->olympic_network_monitor) { /* Must go after register_netdev as we need the device name */ 
 		char proc_name[20] ; 
@@ -281,7 +284,8 @@ op_free_iomap:
 	if (olympic_priv->olympic_lap)
 		iounmap(olympic_priv->olympic_lap);
 
-	free_netdev(dev);
+	if (dev)
+		free_netdev(dev);
 op_release_dev:
 	pci_release_regions(pdev); 
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-04-20  6:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-20  6:52 [PATCH] Olympic (IBM PCI tokenring): handle return codes of register_netdev Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox