* [TCP]: Update references in two old comments
@ 2007-04-27 9:38 Gerrit Renker
2007-04-29 4:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gerrit Renker @ 2007-04-27 9:38 UTC (permalink / raw)
To: David Miller; +Cc: netdev
[TCP]: Update references in two old comments
This updates references to drafts in comments which must be about 10
years old. Internet draft draft-ietf-tcpimpl-prob-03.txt expired in 1998
and was replaced by RFC 2525 in March 1999.
Section 3.10 of the draft maps almost identically into section 2.17 of RFC
2525: both are entitled "Failure to RST on close with data pending", the
differences in text body amount to a typo and minor sentence change.
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
net/ipv4/tcp.c | 14 ++++++--------
net/ipv4/tcp_output.c | 2 +-
2 files changed, 7 insertions(+), 9 deletions(-)
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1573,14 +1573,12 @@ void tcp_close(struct sock *sk, long tim
sk_stream_mem_reclaim(sk);
- /* As outlined in draft-ietf-tcpimpl-prob-03.txt, section
- * 3.10, we send a RST here because data was lost. To
- * witness the awful effects of the old behavior of always
- * doing a FIN, run an older 2.1.x kernel or 2.0.x, start
- * a bulk GET in an FTP client, suspend the process, wait
- * for the client to advertise a zero window, then kill -9
- * the FTP client, wheee... Note: timeout is always zero
- * in such a case.
+ /* As outlined in RFC 2525, section 2.17, we send a RST here because
+ * data was lost. To witness the awful effects of the old behavior of
+ * always doing a FIN, run an older 2.1.x kernel or 2.0.x, start a bulk
+ * GET in an FTP client, suspend the process, wait for the client to
+ * advertise a zero window, then kill -9 the FTP client, wheee...
+ * Note: timeout is always zero in such a case.
*/
if (data_was_unread) {
/* Unread data was tossed, zap the connection. */
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2035,7 +2035,7 @@ void tcp_send_fin(struct sock *sk)
/* We get here when a process closes a file descriptor (either due to
* an explicit close() or as a byproduct of exit()'ing) and there
* was unread data in the receive queue. This behavior is recommended
- * by draft-ietf-tcpimpl-prob-03.txt section 3.10. -DaveM
+ * by RFC 2525, section 2.17. -DaveM
*/
void tcp_send_active_reset(struct sock *sk, gfp_t priority)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [TCP]: Update references in two old comments
2007-04-27 9:38 [TCP]: Update references in two old comments Gerrit Renker
@ 2007-04-29 4:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-04-29 4:21 UTC (permalink / raw)
To: gerrit; +Cc: netdev
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Fri, 27 Apr 2007 10:38:08 +0100
> [TCP]: Update references in two old comments
>
> This updates references to drafts in comments which must be about 10
> years old. Internet draft draft-ietf-tcpimpl-prob-03.txt expired in 1998
> and was replaced by RFC 2525 in March 1999.
>
> Section 3.10 of the draft maps almost identically into section 2.17 of RFC
> 2525: both are entitled "Failure to RST on close with data pending", the
> differences in text body amount to a typo and minor sentence change.
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-29 4:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-27 9:38 [TCP]: Update references in two old comments Gerrit Renker
2007-04-29 4:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox