* [PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests
@ 2007-06-21 16:34 Shannon Nelson
2007-06-24 6:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Shannon Nelson @ 2007-06-21 16:34 UTC (permalink / raw)
To: Dave Miller; +Cc: netdev
This moves the local_irq_enable() call in net_rx_action() to before
calling the CONFIG_NET_DMA's dma_async_memcpy_issue_pending() rather
than after. This shortens the irq disabled window and allows for DMA
drivers that need to do their own irq hold.
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
---
net/core/dev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 2609062..ee051bb 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2009,6 +2009,7 @@ static void net_rx_action(struct softirq_action *h)
}
}
out:
+ local_irq_enable();
#ifdef CONFIG_NET_DMA
/*
* There may not be any more sk_buffs coming right now, so push
@@ -2022,7 +2023,6 @@ out:
rcu_read_unlock();
}
#endif
- local_irq_enable();
return;
softnet_break:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests
2007-06-21 16:34 [PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests Shannon Nelson
@ 2007-06-24 6:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-06-24 6:09 UTC (permalink / raw)
To: shannon.nelson; +Cc: netdev
From: Shannon Nelson <shannon.nelson@intel.com>
Date: Thu, 21 Jun 2007 09:34:55 -0700
> This moves the local_irq_enable() call in net_rx_action() to before
> calling the CONFIG_NET_DMA's dma_async_memcpy_issue_pending() rather
> than after. This shortens the irq disabled window and allows for DMA
> drivers that need to do their own irq hold.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Patch applied, thanks Shannon.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-24 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-21 16:34 [PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests Shannon Nelson
2007-06-24 6:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox