[PATCH net-2.6.24] [TCP]: Update comment about highest_sack validity

[PATCH net-2.6.24] [TCP]: Update comment about highest_sack validity

[Ilpo Järvinen]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 937 bytes --]


This stale info came from the original idea, which proved to be
unnecessarily complex, sacked_out > 0 is easy to do and that when
it's going to be needed anyway (it _can_ be valid also when
sacked_out == 0 but there's not going to be a guarantee about it
for now).

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 include/linux/tcp.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index 1f12fa0..f8cf090 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -332,7 +332,8 @@ struct tcp_sock {
 
 	struct tcp_sack_block_wire recv_sack_cache[4];
 
-	u32	highest_sack;	/* Start seq of globally highest revd SACK (valid only in slowpath) */
+	u32	highest_sack;	/* Start seq of globally highest revd SACK
+				 * (validity guaranteed only if sacked_out > 0) */
 
 	/* from STCP, retrans queue hinting */
 	struct sk_buff* lost_skb_hint;
-- 
1.5.0.6

Re: [PATCH net-2.6.24] [TCP]: Update comment about highest_sack validity

[David Miller]

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Fri, 10 Aug 2007 14:30:46 +0300 (EEST)

> 
> This stale info came from the original idea, which proved to be
> unnecessarily complex, sacked_out > 0 is easy to do and that when
> it's going to be needed anyway (it _can_ be valid also when
> sacked_out == 0 but there's not going to be a guarantee about it
> for now).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>

Patch applied to net-2.6.24