* [PATCH 2/4] /drivers/net ioremap balancing/returncode check (lne390.c)
@ 2007-08-10 18:38 Scott Thompson
0 siblings, 0 replies; only message in thread
From: Scott Thompson @ 2007-08-10 18:38 UTC (permalink / raw)
To: linux-kernel, netdev, kernel-janitors
patchset against 2.6.23-rc2 for /drivers/net ioremap balancing /
return check:
corrects:
--sbus_ioremap return unchecked.
--ioremap function unchecked
--function failure cases did not clean up ioremap'd values.
lne390.c
-- believe had incorrect/not ideal variable check on if for
iounmap
this audit was only for files directly in drivers/net directory,
not the full tree.
I split patches up by file changed as each file had different
'owner' to ease accept/reject/revision process.
Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
----------------------------------------------------------
diff --git a/drivers/net/lne390.c b/drivers/net/lne390.c
index 0a08d0c..f6d9fb6 100644
--- a/drivers/net/lne390.c
+++ b/drivers/net/lne390.c
@@ -290,7 +290,7 @@ static int __init lne390_probe1(struct
net_device *dev, int ioaddr)
goto unmap;
return 0;
unmap:
- if (ei_status.reg0)
+ if (ei_status.mem)
iounmap(ei_status.mem);
cleanup:
free_irq(dev->irq, dev);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-10 18:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-10 18:38 [PATCH 2/4] /drivers/net ioremap balancing/returncode check (lne390.c) Scott Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox