Netdev List
 help / color / mirror / Atom feed
* [PATCH 4/4]  /drivers/net ioremap balancing/returncode check (ucc_geth.c.c)
@ 2007-08-10 18:41 Scott Thompson
  0 siblings, 0 replies; only message in thread
From: Scott Thompson @ 2007-08-10 18:41 UTC (permalink / raw)
  To: linux-kernel, netdev, kernel-janitors

patchset against 2.6.23-rc2 for /drivers/net ioremap balancing / 
return check:

  corrects:
  --sbus_ioremap return unchecked.
  --ioremap function unchecked
  --function failure cases did not clean up ioremap'd values.
  lne390.c
   -- believe had incorrect/not ideal variable check on if for 
iounmap

this audit was only for files directly in drivers/net directory, 
not the full tree.

I split patches up by file changed as each file had different 
'owner' to ease accept/reject/revision process.

Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
----------------------------------------------------------
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 12e01b2..30acbe2 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -2430,6 +2430,11 @@ static int ucc_struct_init(struct 
ucc_geth_private *ugeth)
 
 	ugeth->ug_regs = (struct ucc_geth *) ioremap(uf_info->regs, 
sizeof(struct ucc_geth));
 
+	if (!ugeth->ug_regs){
+		ugeth_err("%s: Failed to ioremap.", __FUNCTION__);
+		return -ENOMEM;
+	}
+
 	return 0;
}


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-08-10 18:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-10 18:41 [PATCH 4/4] /drivers/net ioremap balancing/returncode check (ucc_geth.c.c) Scott Thompson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox