From: Eric Dumazet <dada1@cosmosbay.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] net/core/dst.c : Should'nt dst_run_gc() be more scalable and friendly ?
Date: Fri, 17 Aug 2007 10:10:30 +0200 [thread overview]
Message-ID: <20070817101030.cc64467a.dada1@cosmosbay.com> (raw)
In-Reply-To: <20070816233339.GA11594@gondor.apana.org.au>
On Fri, 17 Aug 2007 07:33:39 +0800
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Thu, Aug 16, 2007 at 05:40:44PM +0200, Eric Dumazet wrote:
> >
> > So do you think this patch is enough or should we convert dst_run_gc processing from softirq to workqueue too ?
>
> I think a workqueue would be the best solution since with
> that you wouldn't have to worry about processing things in
> chunks.
Will a workqueue react the same in case of a DDOS situation,
where softirq could use all CPU cycles to handle incoming
packets and feed the GC list, and GC would never
have a chance to scan and free some items ?
About chunk processing, I did it on purpose, to not throw away
all CPU cache. Goal is to process entries, but not all of them
in a row, especially if we find many yet referenced entries
(and thus not candidates to freeing)
Thanks
next prev parent reply other threads:[~2007-08-17 8:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 12:09 [RFC] net/core/dst.c : Should'nt dst_run_gc() be more scalable and friendly ? Eric Dumazet
2007-08-16 12:41 ` Herbert Xu
2007-08-16 13:36 ` Eric Dumazet
2007-08-16 13:59 ` Herbert Xu
2007-08-16 15:40 ` Eric Dumazet
2007-08-16 23:33 ` Herbert Xu
2007-08-17 8:10 ` Eric Dumazet [this message]
2007-08-17 8:15 ` Herbert Xu
2007-08-17 8:31 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070817101030.cc64467a.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox