Netdev List
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: dada1@cosmosbay.com (Eric Dumazet)
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [RFC] net/core/dst.c : Should'nt dst_run_gc() be more scalable and friendly ?
Date: Thu, 16 Aug 2007 21:59:43 +0800	[thread overview]
Message-ID: <E1ILft1-0001Db-00@gondolin.me.apana.org.au> (raw)
In-Reply-To: <20070816153619.2c699e21.dada1@cosmosbay.com>

Eric Dumazet <dada1@cosmosbay.com> wrote:
> 
> Yes, I already did this (with the current softirq based timer model),
> but how can dst_dev_event() do its work, since the GC is using 
> a private list. (In my patch, time to GC process XXX.000 entries is about XX seconds.)
> 
> We would have to change dst_dev_event() to :
> - Signal to GC it has to stop as soon as possible.
> - Wait for GC be stoped (busy wait I suspect we cannot sleep in dst_dev_event() ? )

You can sleep in dst_dev_event so just use a mutex to separate
it from the GC.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2007-08-16 14:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-16 12:09 [RFC] net/core/dst.c : Should'nt dst_run_gc() be more scalable and friendly ? Eric Dumazet
2007-08-16 12:41 ` Herbert Xu
2007-08-16 13:36   ` Eric Dumazet
2007-08-16 13:59     ` Herbert Xu [this message]
2007-08-16 15:40       ` Eric Dumazet
2007-08-16 23:33         ` Herbert Xu
2007-08-17  8:10           ` Eric Dumazet
2007-08-17  8:15             ` Herbert Xu
2007-08-17  8:31               ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1ILft1-0001Db-00@gondolin.me.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=dada1@cosmosbay.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox