* [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.
@ 2007-09-13 0:30 YOSHIFUJI Hideaki / 吉藤英明
2007-09-13 0:35 ` YOSHIFUJI Hideaki / 吉藤英明
2007-09-15 0:17 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2007-09-13 0:30 UTC (permalink / raw)
To: davem; +Cc: netdev, yoshfuji
Also applicable for stable releases.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
--
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index a58459a..fc5cb83 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -858,11 +858,10 @@ back_from_confirm:
ip6_flush_pending_frames(sk);
else if (!(msg->msg_flags & MSG_MORE))
err = rawv6_push_pending_frames(sk, &fl, rp);
+ release_sock(sk);
}
done:
dst_release(dst);
- if (!inet->hdrincl)
- release_sock(sk);
out:
fl6_sock_release(flowlabel);
return err<0?err:len;
--
YOSHIFUJI Hideaki @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.
2007-09-13 0:30 [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM YOSHIFUJI Hideaki / 吉藤英明
@ 2007-09-13 0:35 ` YOSHIFUJI Hideaki / 吉藤英明
2007-09-13 8:12 ` David Miller
2007-09-15 0:17 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2007-09-13 0:35 UTC (permalink / raw)
To: davem; +Cc: netdev, yoshfuji
| [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.
Ah, I should say, socket locking, probably...
Anyway, lock_sock() and release_sock() are not paired approriately.
--yoshfuji
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.
2007-09-13 0:35 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2007-09-13 8:12 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2007-09-13 8:12 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Thu, 13 Sep 2007 09:35:28 +0900 (JST)
> | [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.
>
> Ah, I should say, socket locking, probably...
> Anyway, lock_sock() and release_sock() are not paired approriately.
Thanks for these fixes, I'll merge these in as soon as I
can, which might take a little bit since I'm traveling today.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.
2007-09-13 0:30 [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM YOSHIFUJI Hideaki / 吉藤英明
2007-09-13 0:35 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2007-09-15 0:17 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2007-09-15 0:17 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Thu, 13 Sep 2007 09:30:39 +0900 (JST)
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied, I'll push to -stable after it lands in Linus's tree.
Thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-09-15 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-13 0:30 [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM YOSHIFUJI Hideaki / 吉藤英明
2007-09-13 0:35 ` YOSHIFUJI Hideaki / 吉藤英明
2007-09-13 8:12 ` David Miller
2007-09-15 0:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox