* Re: [Bugme-new] [Bug 9128] New: PF_KEY SADB_GET messages return SADB_DUMP from the kernel
[not found] <bug-9128-10286@http.bugzilla.kernel.org/>
@ 2007-10-05 17:37 ` Andrew Morton
2007-10-06 1:15 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2007-10-05 17:37 UTC (permalink / raw)
To: netdev, chardin
Cc: bugme-daemon, Joy Latten, Eric Paris, James Morris, Herbert Xu
(Please reply via emailed reply-to-all, not via the bugzilla web interface)
On Fri, 5 Oct 2007 09:01:50 -0700 (PDT)
bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9128
>
> Summary: PF_KEY SADB_GET messages return SADB_DUMP from the
> kernel
> Product: Networking
> Version: 2.5
> KernelVersion: 2.6.18
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Other
> AssignedTo: acme@ghostprotocols.net
> ReportedBy: chardin@2wire.com
>
>
> Most recent kernel where this bug did not occur:
> Distribution: Centos 5
> Hardware Environment: Dell 490
> Software Environment: Centos 5
> Problem Description:
> Sending an SADB_GET to the PF_KEY socket returns an SADB_DUMP in the out_hdr
>
> Steps to reproduce:
> Send an SADB_GET to the PF_KEY socket and dump the returned packet
>
>
> This patch should fix the problem
> diff --git a/net/key/af_key.c b/net/key/af_key.c
> index 5502df1..7a5e993 100644
> --- a/net/key/af_key.c
> +++ b/net/key/af_key.c
> @@ -1546,7 +1546,7 @@ static int pfkey_get(struct sock *sk, struct sk_buff
> *skb,
>
> out_hdr = (struct sadb_msg *) out_skb->data;
> out_hdr->sadb_msg_version = hdr->sadb_msg_version;
> - out_hdr->sadb_msg_type = SADB_DUMP;
> + out_hdr->sadb_msg_type = SADB_GET;
> out_hdr->sadb_msg_satype = pfkey_proto2satype(proto);
> out_hdr->sadb_msg_errno = 0;
> out_hdr->sadb_msg_reserved = 0;
>
Please submit kernel patches via email, as per
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt. Net patches
should be sent to netdev@vger.kernel.org and perhaps
linux-kernel@vger.kernel.org.
But whatever - I can convert this patch into a suitable one and send it in
to David if people think it is good?
^ permalink raw reply [flat|nested] 2+ messages in thread