Netdev List
 help / color / mirror / Atom feed
* [patch 2/4] tokenring/3c359.c: fixed array index problem
@ 2007-10-16 21:24 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-10-16 21:24 UTC (permalink / raw)
  To: jeff; +Cc: netdev, akpm, meissner, penberg

From: Marcus Meissner <meissner@suse.de>

The xl_laa array is just 6 bytes long, so we should substract 10 from the
index, like is also done some lines above already.

Signed-off-by: Marcus Meissner <meissner@suse.de>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/net/tokenring/3c359.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/tokenring/3c359.c~tokenring-3c359c-fixed-array-index-problem drivers/net/tokenring/3c359.c
--- a/drivers/net/tokenring/3c359.c~tokenring-3c359c-fixed-array-index-problem
+++ a/drivers/net/tokenring/3c359.c
@@ -760,7 +760,7 @@ static int xl_open_hw(struct net_device 
 	if (xl_priv->xl_laa[0]) {  /* If using a LAA address */
 		for (i=10;i<16;i++) { 
 			writel( (MEM_BYTE_WRITE | 0xD0000 | xl_priv->srb) + i, xl_mmio + MMIO_MAC_ACCESS_CMD) ; 
-			writeb(xl_priv->xl_laa[i],xl_mmio + MMIO_MACDATA) ; 
+			writeb(xl_priv->xl_laa[i-10], xl_mmio + MMIO_MACDATA);
 		}
 		memcpy(dev->dev_addr,xl_priv->xl_laa,dev->addr_len) ; 
 	} else { /* Regular hardware address */ 
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-10-16 21:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-16 21:24 [patch 2/4] tokenring/3c359.c: fixed array index problem akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox