Netdev List
 help / color / mirror / Atom feed
From: Joakim Koskela <joakim.koskela@hiit.fi>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	"Patrick McHardy" <kaber@trash.net>,
	"Herbert Xu" <herbert@gondor.apana.org.au>
Subject: [PATCH] netdev: Reset ipv4 flags during bundle creation on interfamily ipsec
Date: Fri, 19 Oct 2007 14:40:16 +0300	[thread overview]
Message-ID: <200710191440.17232.joakim.koskela@hiit.fi> (raw)
In-Reply-To: <200710191437.39449.joakim.koskela@hiit.fi>

This patch resets the ipv4-related flags in the new flow as their
content will otherwise depend on the bits of the ipv6 addresses the
struct was previously used for. For example, fl4_tos might have
RTO_ONLINK set, which usually prevents the right route from being
found.

This bit was chopped off the larger patch dealing with the problems
related to creating the bundles for inter-family tranformations.

Signed-off-by: Joakim Koskela <jookos@gmail.com>
--

diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
index 82e27b8..386a762 100644
--- a/net/ipv6/xfrm6_policy.c
+++ b/net/ipv6/xfrm6_policy.c
@@ -184,6 +184,8 @@ __xfrm6_bundle_create(struct xfrm_policy *policy, struct xfrm_state **xfrm, int
 			case AF_INET:
 				fl_tunnel.fl4_dst = xfrm[i]->id.daddr.a4;
 				fl_tunnel.fl4_src = xfrm[i]->props.saddr.a4;
+				fl_tunnel.fl4_tos = 0;
+				fl_tunnel.fl4_scope = 0;
 				break;
 			case AF_INET6:
 				ipv6_addr_copy(&fl_tunnel.fl6_dst, __xfrm6_bundle_addr_remote(xfrm[i], &fl->fl6_dst));

  reply	other threads:[~2007-10-19 11:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 11:37 [PATCH] netdev: Netfilters on outgoing interfamily ipsec Joakim Koskela
2007-10-19 11:40 ` Joakim Koskela [this message]
2007-10-19 13:09   ` [PATCH] netdev: Reset ipv4 flags during bundle creation on " Herbert Xu
2007-10-19 13:20     ` Joakim Koskela
2007-10-19 14:25       ` Herbert Xu
2007-10-22  6:55         ` Joakim Koskela
2007-10-22  8:51           ` Herbert Xu
2007-10-19 12:55 ` [PATCH] netdev: Netfilters on outgoing " Herbert Xu
2007-10-19 13:18   ` Joakim Koskela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710191440.17232.joakim.koskela@hiit.fi \
    --to=joakim.koskela@hiit.fi \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox